Collecting all plugin models and prevent repeated lookup#2056
Closed
laeubi wants to merge 1 commit intoeclipse-pde:masterfrom
Closed
Collecting all plugin models and prevent repeated lookup#2056laeubi wants to merge 1 commit intoeclipse-pde:masterfrom
laeubi wants to merge 1 commit intoeclipse-pde:masterfrom
Conversation
Currently we add the models we convert the model we have looked up from the id into a bundle description, just to later match them up to models again. This now stores all collected models for later usage and to prepare for additional filtering.
laeubi
force-pushed
the
streamline_collection
branch
from
ee530f0 to
d70df04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we add the models we convert the model we have looked up from the id into a bundle description, just to later match them up to models again.
This now stores all collected models for later usage and to prepare for additional filtering.
This is an extract from:
and later can be used to properly filter invalid providers from the launch.