TargetPlatformHelper.java - Performance & Readability Improvements #2060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I assume the build will fail (PDE build is currently not working), so I plan to leave this here and return to it, once PDE build are green again. |
|
|
||
| private static Map<String, String> fgCachedLocations; | ||
| private static Map<ITargetHandle, List<TargetDefinition>> fgCachedTargetDefinitionMap = new HashMap<>(); | ||
| // Use concurrent map to avoid synchronization overhead on read operations |
Member
There was a problem hiding this comment.
comment doesn't match code
| } | ||
| } | ||
| return list.toArray(new String[list.size()]); | ||
| return Arrays.stream(models) |
Member
There was a problem hiding this comment.
This is highly questionable, as it makes no improvement functionally, and makes debugging impossible.
Test Results 745 files - 26 745 suites - 26 47m 32s ⏱️ - 12m 17s For more details on these failures, see this check. Results for commit e4cac57. ± Comparison against base commit f2cc40b. ♻️ This comment has been updated with latest results. |
Optimized regex pattern compilation by precompiling PATTERN_PATH_COLON pattern used in stripPathInformation() method. Simplified switch expression in getTargetVersionString() and improved thread-safety in addTargetDefinitionMap() using computeIfAbsent(). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
vogella
force-pushed
the
target-platform-helper
branch
from
f57d3be to
e4cac57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizations:
improvement in hot paths
much cleaner and more maintainable
simplify logic
Impact: