Add version constraints to junit-platform-launcher added in plug-in launch#2068
Conversation
|
Note that this PR requires changes in JDT UI that were done today, we should wait some time before trying to merge it. |
Test Results 623 files ±0 623 suites ±0 50m 44s ⏱️ -23s For more details on these failures, see this check. Results for commit 497875a. ± Comparison against base commit 08a144c. ♻️ This comment has been updated with latest results. |
|
Jenkins build failed with OOM again (eclipse-platform/eclipse.platform.releng.aggregator#3436) |
Well it seems cheaper to use developers "resources" and rerun builds over and over again than to plug in some RAM into a virtual maschine :-\ As of today Github offers already Linux with 4 cores @ 16 GB by default while Jenkis is still creeping with 2 cores and 4GB ... |
|
I have asked: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4759 I think most project don't actually need the more resource so it could be wasteful to make that the default, but I have yet to figure out how to allocate a bigger instance... |
bbfb04c to
d78151f
Compare
HannesWell
left a comment
There was a problem hiding this comment.
Looks good.
The build should also succeed now.
d78151f to
f916980
Compare
f916980 to
c6d9a07
Compare
c6d9a07 to
497875a
Compare
|
Seems like I forgot about this PR. Lets merge it this week, it shouldn't do harm. |
|
Fail in the Linux build is: |
|
@iloveeclipse can we merge this? Its a left-over I forgot about. |
See eclipse-jdt/eclipse.jdt.ui#2572 and eclipse-jdt/eclipse.jdt.ui#2574. Similar to what we have in JDT, we add a version range to
junit-platform-launcheradded inJUnitPluginLaunchConfigurationDelegate.