Skip to content

Conversation

@trancexpress
Copy link
Contributor

@trancexpress trancexpress commented Oct 27, 2025

See eclipse-jdt/eclipse.jdt.ui#2572 and eclipse-jdt/eclipse.jdt.ui#2574. Similar to what we have in JDT, we add a version range to junit-platform-launcher added in JUnitPluginLaunchConfigurationDelegate.

@trancexpress
Copy link
Contributor Author

Note that this PR requires changes in JDT UI that were done today, we should wait some time before trying to merge it.

@github-actions
Copy link

github-actions bot commented Oct 27, 2025

Test Results

   771 files  +  257     771 suites  +257   57m 5s ⏱️ + 20m 48s
 3 634 tests ±    0   3 580 ✅ ±    0   54 💤 ± 0  0 ❌ ±0 
10 836 runs  +3 612  10 673 ✅ +3 558  163 💤 +54  0 ❌ ±0 

Results for commit c6d9a07. ± Comparison against base commit 8d8b12d.

♻️ This comment has been updated with latest results.

@iloveeclipse
Copy link
Member

Jenkins build failed with OOM again (eclipse-platform/eclipse.platform.releng.aggregator#3436)

19:46:32  [ERROR] Failed to execute goal org.eclipse.tycho:tycho-source-plugin:5.0.1-SNAPSHOT:plugin-source (plugin-source) on project org.eclipse.pde.ui: Error creating source archive: Problem creating jar: Execution exception: Java heap space -> [Help 1]

@laeubi
Copy link
Contributor

laeubi commented Oct 28, 2025

Jenkins build failed with OOM again (eclipse-platform/eclipse.platform.releng.aggregator#3436)

19:46:32  [ERROR] Failed to execute goal org.eclipse.tycho:tycho-source-plugin:5.0.1-SNAPSHOT:plugin-source (plugin-source) on project org.eclipse.pde.ui: Error creating source archive: Problem creating jar: Execution exception: Java heap space -> [Help 1]

Well it seems cheaper to use developers "resources" and rerun builds over and over again than to plug in some RAM into a virtual maschine :-\

As of today Github offers already Linux with 4 cores @ 16 GB by default while Jenkis is still creeping with 2 cores and 4GB ...

@merks
Copy link
Contributor

merks commented Oct 28, 2025

I have asked:

https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4759

I think most project don't actually need the more resource so it could be wasteful to make that the default, but I have yet to figure out how to allocate a bigger instance...

@HannesWell HannesWell force-pushed the jdtui_gh2572 branch 2 times, most recently from bbfb04c to d78151f Compare October 30, 2025 23:33
Copy link
Member

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
The build should also succeed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants