-
Notifications
You must be signed in to change notification settings - Fork 121
Add version constraints to junit-platform-launcher added in plug-in launch #2068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Note that this PR requires changes in JDT UI that were done today, we should wait some time before trying to merge it. |
|
Jenkins build failed with OOM again (eclipse-platform/eclipse.platform.releng.aggregator#3436) |
Well it seems cheaper to use developers "resources" and rerun builds over and over again than to plug in some RAM into a virtual maschine :-\ As of today Github offers already Linux with 4 cores @ 16 GB by default while Jenkis is still creeping with 2 cores and 4GB ... |
|
I have asked: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4759 I think most project don't actually need the more resource so it could be wasteful to make that the default, but I have yet to figure out how to allocate a bigger instance... |
bbfb04c to
d78151f
Compare
HannesWell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
The build should also succeed now.
d78151f to
f916980
Compare
f916980 to
c6d9a07
Compare
See eclipse-jdt/eclipse.jdt.ui#2572 and eclipse-jdt/eclipse.jdt.ui#2574. Similar to what we have in JDT, we add a version range to
junit-platform-launcheradded inJUnitPluginLaunchConfigurationDelegate.