Skip to content

Conversation

@HannesWell
Copy link
Member

Part of #1881

@laeubi
Copy link
Contributor

laeubi commented Nov 3, 2025

Can you provide a Screenshot before/after? If it do what I suspect it to do I do not think it is a good default as it vast valuable space for people using import package ...

@HannesWell HannesWell force-pushed the expand-dependency-analysis branch from f050987 to 2f7e8c6 Compare November 3, 2025 15:31
@HannesWell HannesWell marked this pull request as draft November 3, 2025 15:31
@HannesWell
Copy link
Member Author

Can you provide a Screenshot before/after?

Sure. Before it looks like this:

afterwards like this:

If it do what I suspect it to do I do not think it is a good default as it vast valuable space for people using import package ...

It takes indeed some space from the Import Packages section, but as it's only a little bit there is IMO still sufficient space for the Import Packages section.

But as mentioned in #1881 (comment), this was mainly created to serve as a live-demo at the OCX webinar today.

@laeubi
Copy link
Contributor

laeubi commented Nov 3, 2025

The Form Framework is really quite wasting space for little benefit. So if we really want to make this more accessible we better move it somewhere else and remove the section all together.

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Test Results

   771 files  ±0     771 suites  ±0   1h 2m 56s ⏱️ + 2m 49s
 3 633 tests ±0   3 579 ✅ ±0   54 💤 ±0  0 ❌ ±0 
10 833 runs  ±0  10 670 ✅ ±0  163 💤 ±0  0 ❌ ±0 

Results for commit 2f7e8c6. ± Comparison against base commit 2b81907.

@HannesWell
Copy link
Member Author

The Form Framework is really quite wasting space for little benefit. So if we really want to make this more accessible we better move it somewhere else and remove the section all together.

It is indeed not very efficient. In this case it could for example place the elements in a 2x2 grid...
On the other hand I'm not sure if moving it for example to the toolbar would be a better user experience overall.
In the MANIFEST editor there are already 5 toolbar elements and adding three or four (the first two elements could be combined) could make it look cluttered.
And the current style has the advantage that it has an immediately readable text.
Furthermore the location in the Dependencies section also fits quite well IMHO.

But I also understand that some might want to use that space to see more of the imported packages.
I'm torn on this and it probably depends on what one wants.

What's the opinion of others?

@laeubi
Copy link
Contributor

laeubi commented Nov 6, 2025

Just mentioning it, you can have text in toolbars as well.

Apart form that, no one has the need to have text / a big expandable section for all the other functions in Eclipse we have at the toolbars all over the place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants