Skip optional dependencies in new JUnit Plug-in test launches by default #2103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a dependency is optional then the code must be ready to handle the absence. And if it cannot be absent, then the requirement should be mandatory. If the bundle itself can work without that requirement but some other bundle needs the first bundle to work with that optional dependency, then that other bundle has to declare a corresponding mandatory requirement. On the other hand, considering optional dependencies can drag bundles into the runtime that are not desired and even can cause harm. And because it's not possible to remove undesired bundles with some other configuration, it's better to start with less and explicitly add what's a missing mandatory requirement.
Test Results 623 files ±0 623 suites ±0 47m 45s ⏱️ + 3m 35s For more details on these failures, see this check. Results for commit 705cfef. ± Comparison against base commit 4fe820b. |
laeubi
requested changes
Nov 6, 2025
Contributor
laeubi
left a comment
laeubi
left a comment
There was a problem hiding this comment.
I don't think this is good and it was chosen by purpose.
The default should "just work" and disable it because we have bad bundles is not really a viable option. Of course people can choose to use other defaults if they feel more comfortable with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a dependency is optional then the code must be ready to handle the absence. And if it cannot be absent, then the requirement should be mandatory. If the bundle itself can work without that requirement but some other bundle needs the first bundle to work with that optional dependency, then that other bundle has to declare a corresponding mandatory requirement.
On the other hand, considering optional dependencies can drag bundles into the runtime that are not desired and even can cause harm. And because it's not possible to remove undesired bundles with some other configuration, it's better to start with less and explicitly add what's a missing mandatory requirement.
See for example #2092 (comment) ff.