Remove compilation error resolution proposal for adding Junit 5 bundles

[HannesWell]

For junit-5 it's sufficient and recommended to just import the packages needed for compilation. Alternatively it's also possible to require the junit-jupiter-api bundle.

Both is already proposed by default and in both cases it's not necessary to require the junit-4 bundle (org.junit) too.

As this extra proposal also complicates the code significantly, it is removed with the recommendation to use the other standard proposals in case of missing JUnit-5 dependencies too.

Furthermore the current code seems to be partially incorrect, because actually package names have to be checked while it seems that the code assumed bundle names (which only coincidentally match).

Removing it also avoids the need to handle the JUnit-6 case too.

This was initially proposed in

• Restrict junit-jupiter-api version to [5,6) when adding JUnit 5 bundle requirements #2053 (comment)

With this, the proposals are now (#2053 (comment) contains the previous state):

In a follow-up PR the proposals should be further enhanced to

• show package-imports at the top
• remove duplicated proposals
• show versions and propose multiple versions if available.

[github-actions]

Test Results

   771 files  +  257     771 suites  +257   53m 22s ⏱️ + 17m 5s
 3 634 tests ±    0   3 580 ✅ ±    0   54 💤 ± 0  0 ❌ ±0 
10 836 runs  +3 612  10 673 ✅ +3 558  163 💤 +54  0 ❌ ±0 

Results for commit c788f66. ± Comparison against base commit 8d8b12d.

♻️ This comment has been updated with latest results.

[laeubi]

This sounds reasonable to me also moving package imports to the top would be great.

[trancexpress]

Thinking about this, maybe this was done before it was enough to add junit-jupiter-api to the dependencies. So at that time likely it made sense to have an extra fix proposal.

[HannesWell]

Thinking about this, maybe this was done before it was enough to add junit-jupiter-api to the dependencies. So at that time likely it made sense to have an extra fix proposal.

Yes that's likely the case. It was done quite some time ago and in the meantime a lot was improved in the area of launching Eclipse apps with respect to adding dependencies automatically, not only for tests (and through the OSGi metadata of junit itself) but also generally.

But I'm glad we can now remove this.