Skip to content

Updating plug-in dependencies job should provide project information#2148

Merged
vogella merged 1 commit intomasterfrom
update-classpath-job-should-give-project-info
Dec 3, 2025
Merged

Updating plug-in dependencies job should provide project information#2148
vogella merged 1 commit intomasterfrom
update-classpath-job-should-give-project-info

Conversation

@vogella
Copy link
Contributor

@vogella vogella commented Dec 2, 2025

Updating plug-in dependencies can sometimes run relatively long, in its current form it give no indication which project requires a lot of time.

This adds the info, which project is currently updated.

@github-actions
Copy link

github-actions bot commented Dec 2, 2025

Test Results

   771 files  ±0     771 suites  ±0   58m 39s ⏱️ -21s
 3 648 tests ±0   3 594 ✅ +3   54 💤 ±0  0 ❌  - 3 
10 878 runs  ±0  10 715 ✅ +3  163 💤 ±0  0 ❌  - 3 

Results for commit 4a3e734. ± Comparison against base commit 2ecbcf2.

♻️ This comment has been updated with latest results.

@eclipse-pde-bot
Copy link
Contributor

eclipse-pde-bot commented Dec 2, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ui/org.eclipse.pde.core/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From c88eaa01bb0159f9ab9cda2fd7aecae6685081f1 Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <pde-bot@eclipse.org>
Date: Wed, 3 Dec 2025 12:01:15 +0000
Subject: [PATCH] Version bump(s) for 4.39 stream


diff --git a/ui/org.eclipse.pde.core/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.core/META-INF/MANIFEST.MF
index a83a7c3f04..d1d5acc8e3 100644
--- a/ui/org.eclipse.pde.core/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.core/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %name
 Bundle-SymbolicName: org.eclipse.pde.core; singleton:=true
-Bundle-Version: 3.21.100.qualifier
+Bundle-Version: 3.21.200.qualifier
 Bundle-Activator: org.eclipse.pde.internal.core.PDECore
 Bundle-Vendor: %provider-name
 Bundle-Localization: plugin
-- 
2.52.0

Further information are available in Common Build Issues - Missing version increments.

@vogella vogella force-pushed the update-classpath-job-should-give-project-info branch from e9b19e9 to 0e84704 Compare December 3, 2025 11:58
@vogella
Copy link
Contributor Author

vogella commented Dec 3, 2025

This is how it looks like:

image

@vogella
Copy link
Contributor Author

vogella commented Dec 3, 2025

image

Comment on lines 110 to 112
monitor.subTask(project.getName());
if (project.exists() && project.isOpen()) {
IPluginModelBase model = modelManager.findModel(project);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
monitor.subTask(project.getName());
if (project.exists() && project.isOpen()) {
IPluginModelBase model = modelManager.findModel(project);
if (project.exists() && project.isOpen()) {
monitor.subTask(project.getName());
IPluginModelBase model = modelManager.findModel(project);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@vogella vogella force-pushed the update-classpath-job-should-give-project-info branch 2 times, most recently from 4bddb10 to 33f485d Compare December 3, 2025 14:12
Updating plug-in dependencies can sometimes run relatively long, in its
current form it give no indication which project requires a lot of time.

This adds the info, which project is currently updated.
@vogella vogella force-pushed the update-classpath-job-should-give-project-info branch from 33f485d to 4a3e734 Compare December 3, 2025 15:23
@vogella
Copy link
Contributor Author

vogella commented Dec 3, 2025

AllPDETests AllLauncherTests PluginBasedLaunchTest.testGetMergedBundleMap_automaticAddedWorkspacePlugins_sameMMMVersionButDifferentQualifier looks unrelated.

@vogella vogella merged commit 1c1d663 into master Dec 3, 2025
16 of 19 checks passed
@vogella vogella deleted the update-classpath-job-should-give-project-info branch December 3, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants