Delete Icon Directories for Platform UI Bundles #143
Conversation
Michael5601
force-pushed
the
Delete-Platform-UI-Bundles
branch
from
e481548 to
69064c2
Compare
|
And I thought the images where safe to use from there. 😜
Time to revisit that assumption... |
|
shouldn't we also delete the corresponding PNG folders? |
Most SVGs were added directly to the eclipse bundles which removes the need for maintaining icons in the images repository. This commit deletes all folders of Platform UI bundles in the images repository where all SVGs are existing and already copied directly to the specific bundle. For Platform UI this is the case for every folder. The following folders will be deleted: `org.eclipse.e4.ui.dialogs` `org.eclipse.e4.ui.progress` `org.eclipse.e4.ui.workbench.addons.swt` `org.eclipse.e4.ui.workbench.renderers.swt` `org.eclipse.e4.ui.workbench.swt` `org.eclipse.jface.notifications` `org.eclipse.jface.text` `org.eclipse.jface` `org.eclipse.search` `org.eclipse.ui.browser` `org.eclipse.ui.editors` `org.eclipse.ui.forms` `org.eclipse.ui.genericeditor` `org.eclipse.ui.ide.application` `org.eclipse.ui.ide` `org.eclipse.ui.navigator.resources` `org.eclipse.ui.navigator` `org.eclipse.ui.views.log` `org.eclipse.ui.views` `org.eclipse.ui.workbench.texteditor` `org.eclipse.ui` `org.eclipse.ltk.ui.refactoring`
Michael5601
force-pushed
the
Delete-Platform-UI-Bundles
branch
from
69064c2 to
fcf08ed
Compare
Done. |
|
@merks so should these removal PRs be postponed as Oomph relies on the images being present in this repo? |
|
No, definitely not. I just need to use the URIs for the new locations and all will be good. Thanks for asking. |
|
@merks please merge once you are ready with the Oomph change |
laeubi
left a comment
laeubi
left a comment
There was a problem hiding this comment.
We must include the SVGs then (and adjust the generated manifest to require the swt-svg feature), same as in #142 (comment)
|
Why are the SVGs delete here? Please look at the maven build that creates a bundle so other RCP products can use the images as well. |
|
IIRC the goal is for this repo to disappear entirely over time. |
But why? Its already bad enough we currently forced to copy thing multiple times instead of having a single source so why now force others to do the same? Also I find it quite convenient to checkout all images and look at them without first finding the bundle that host an image then checkout the full repo then go on again with another icon... See also this discussion: |
|
IIRC There have been cases of changing icons in eclipse but not here and an effort to remove this extra syncing step. As icon handling is more than suboptimal with or without this one for me I don't have more to say here and will let you guys figure it out. |
|
Seems I can't dismiss my review here unless conflicts are resolved.... |
7 participants
Most SVGs were added directly to the eclipse bundles which removes the need for maintaining icons in the images repository. This PR deletes all folders of Platform UI bundles in the images repository where all SVGs are existing and already copied directly to the specific bundle. For Platform UI bundles this is the case for every folder, so they all will be deleted.
The following directories will be deleted:
org.eclipse.e4.ui.dialogsorg.eclipse.e4.ui.progressorg.eclipse.e4.ui.workbench.addons.swtorg.eclipse.e4.ui.workbench.renderers.swtorg.eclipse.e4.ui.workbench.swtorg.eclipse.jface.notificationsorg.eclipse.jface.textorg.eclipse.jfaceorg.eclipse.searchorg.eclipse.ui.browserorg.eclipse.ui.editorsorg.eclipse.ui.formsorg.eclipse.ui.genericeditororg.eclipse.ui.ide.applicationorg.eclipse.ui.ideorg.eclipse.ui.navigator.resourcesorg.eclipse.ui.navigatororg.eclipse.ui.views.logorg.eclipse.ui.viewsorg.eclipse.ui.workbench.texteditororg.eclipse.uiorg.eclipse.ltk.ui.refactoringAll missing SVGs are tracked in this issue.