Skip to content

Add OSGi test dependencies #2822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laeubi merged 1 commit into from
Mar 6, 2025
Merged

Add OSGi test dependencies #2822

laeubi merged 1 commit into from
Mar 6, 2025

Conversation

@laeubi
Copy link
Contributor

@laeubi laeubi commented Feb 15, 2025

@laeubi
Copy link
Contributor Author

laeubi commented Feb 15, 2025

/request-license-review

@github-actions
Copy link
Contributor

github-actions bot commented Feb 15, 2025

/request-license-review

✔️ All licenses already successfully vetted.

Workflow run (with attached summary files):
https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/actions/runs/13347069750

merks
merks reviewed Feb 15, 2025
View reviewed changes
@laeubi laeubi force-pushed the add_osgi_test_dependencies branch from 0f8fa12 to 4477354 Compare February 16, 2025 06:14
@laeubi
Copy link
Contributor Author

laeubi commented Feb 16, 2025

/request-license-review

@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2025

/request-license-review

✔️ All licenses already successfully vetted.

Workflow run (with attached summary files):
https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/actions/runs/13352416363

@laeubi laeubi mentioned this pull request Feb 16, 2025
Merged
2 tasks
merks
merks requested changes Feb 16, 2025
View reviewed changes
Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to avoid following dependencies and ignoring non-OSGi MANIFEST.MF.

@laeubi laeubi force-pushed the add_osgi_test_dependencies branch 3 times, most recently from 6181cd4 to cb25310 Compare February 16, 2025 08:09
@merks merks self-requested a review February 16, 2025 09:08
merks
merks approved these changes Feb 16, 2025
View reviewed changes
Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

merks added a commit to eclipse-orbit/orbit-simrel that referenced this pull request Feb 16, 2025
@merks
Add OSGi test dependencies
253a19b 
eclipse-platform/eclipse.platform.releng.aggregator#2822
@laeubi laeubi force-pushed the add_osgi_test_dependencies branch from cb25310 to 1aea42d Compare February 19, 2025 08:25
@laeubi
Copy link
Contributor Author

laeubi commented Feb 19, 2025

/request-license-review

@github-actions
Copy link
Contributor

github-actions bot commented Feb 19, 2025

/request-license-review

License review requests:

After all reviews have concluded, re-run the license-vetting check from the Github Actions web-interface to update its status.

Workflow run (with attached summary files):
https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/actions/runs/13408377166

@laeubi laeubi force-pushed the add_osgi_test_dependencies branch from 1aea42d to 10f3b1e Compare February 19, 2025 18:21
@laeubi
Copy link
Contributor Author

laeubi commented Feb 19, 2025

/request-license-review

@github-actions
Copy link
Contributor

github-actions bot commented Feb 19, 2025

/request-license-review

License review requests:

After all reviews have concluded, re-run the license-vetting check from the Github Actions web-interface to update its status.

Workflow run (with attached summary files):
https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/actions/runs/13419636890

@laeubi laeubi force-pushed the add_osgi_test_dependencies branch 2 times, most recently from b50b94c to 7eed449 Compare March 4, 2025 09:54
@laeubi laeubi marked this pull request as ready for review March 4, 2025 09:54
@laeubi laeubi force-pushed the add_osgi_test_dependencies branch from 7eed449 to 49a5887 Compare March 5, 2025 09:42
@laeubi
Copy link
Contributor Author

laeubi commented Mar 5, 2025

/request-license-review

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025

/request-license-review

✔️ All licenses already successfully vetted.

Workflow run (with attached summary files):
https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/actions/runs/13672997291

@laeubi laeubi force-pushed the add_osgi_test_dependencies branch from 49a5887 to a286606 Compare March 6, 2025 11:59
@laeubi laeubi merged commit 2e999bb into eclipse-platform:master Mar 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merks merks merks approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@laeubi @merks