-
Notifications
You must be signed in to change notification settings - Fork 88
[Build] Add GH workflow build for aggregator #2999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[Build] Add GH workflow build for aggregator #2999
Conversation
e663dab
to
ad11916
Compare
I think doing it in a nightly way as (temporary) replacement of I-Builds would make sense. In addition, I would be in favor of adding the |
3bba108
to
06afe80
Compare
568f55e
to
49066fd
Compare
e98a592
to
97216ce
Compare
97216ce
to
8ccc9fd
Compare
Probably due to eclipse-platform/eclipse.platform.swt#2077, the workarounds to make swt.svg compile are not necessary anymore. Thanks for the fix.
And currently I have no idea why. |
|
Yes sure, I meant why this does not appear somewhere else. But I just noticed that SWT is the only project that doesn't build the javadoc in verification builds. I'm about that change that and fix all the errors in: |
8ccc9fd
to
0a51543
Compare
@HannesWell You can of course just remove my commit in this PR instead of adding a revert commit. It was just for testing purposes to work around the infrastructure issues but it turned out that one of the issues was actually a general build issue that meanwhile was fixed: eclipse-platform/eclipse.platform.swt#2077 Even though the infrastructure issues have been resolved for now, I would be in favor of contributing this workflow to be dispatched manually, so that one can trigger an aggregator build if required without waiting for the nightly I-Build. One possible extension might be to introduce a branch tag pattern to execute the workflow, such that one can for example test changes across multiple repos by changing the .gitmodules branches accordingly and then triggering the workflow proposed here on that state. |
What is the status of this one? |
In order to mitigate the current outage of the EF-hosted storage, which will probably continue to block builds for at least a few days (https://www.eclipse.org/lists/eclipse.org-committers/msg01493.html) this adds a GH workflow to build the entire Eclipse SDK respectively the
eclipse.platform.releng.aggregator
(so this) repository.Besides just simply building all modules together, this also enables javadoc generation and compilation of the current source-state of ECJ.
Of course this doesn't give the full I-build experience, but it gives at least a little bit more confidence.
What I'm currently not sure of if this should run on a time-trigger, on dispatch or if we just keep this PR open until the infra-outage is fixed and rebase/rerun it on our own discretion if desired.