Skip to content

[Build] Add GH workflow build for aggregator #2999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

HannesWell
Copy link
Member

In order to mitigate the current outage of the EF-hosted storage, which will probably continue to block builds for at least a few days (https://www.eclipse.org/lists/eclipse.org-committers/msg01493.html) this adds a GH workflow to build the entire Eclipse SDK respectively the eclipse.platform.releng.aggregator (so this) repository.
Besides just simply building all modules together, this also enables javadoc generation and compilation of the current source-state of ECJ.
Of course this doesn't give the full I-build experience, but it gives at least a little bit more confidence.

What I'm currently not sure of if this should run on a time-trigger, on dispatch or if we just keep this PR open until the infra-outage is fixed and rebase/rerun it on our own discretion if desired.

@HannesWell HannesWell force-pushed the add-aggregator-gh-build branch 3 times, most recently from e663dab to ad11916 Compare April 27, 2025 07:18
@HeikoKlare
Copy link
Contributor

What I'm currently not sure of if this should run on a time-trigger, on dispatch or if we just keep this PR open until the infra-outage is fixed and rebase/rerun it on our own discretion if desired.

I think doing it in a nightly way as (temporary) replacement of I-Builds would make sense. In addition, I would be in favor of adding the workflow_dispatch event, so that we can manually trigger it on demand. That might be useful even beyond the current infrastructure issues.

@HannesWell HannesWell force-pushed the add-aggregator-gh-build branch 5 times, most recently from 3bba108 to 06afe80 Compare April 28, 2025 06:08
@HannesWell HannesWell force-pushed the add-aggregator-gh-build branch 2 times, most recently from 568f55e to 49066fd Compare April 28, 2025 17:39
@HeikoKlare HeikoKlare force-pushed the add-aggregator-gh-build branch 5 times, most recently from e98a592 to 97216ce Compare April 30, 2025 12:53
@HannesWell HannesWell force-pushed the add-aggregator-gh-build branch from 97216ce to 8ccc9fd Compare May 1, 2025 12:46
@HannesWell
Copy link
Member Author

Probably due to eclipse-platform/eclipse.platform.swt#2077, the workarounds to make swt.svg compile are not necessary anymore. Thanks for the fix.
But still this fails with javadoc generation errors:

Error:  Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.11.2:jar (attach-javadocs) on project org.eclipse.swt.gtk.linux.x86_64: MavenReportException: Error while generating Javadoc: 
Error:  Exit code: 1
Error:  /home/runner/work/eclipse.platform.releng.aggregator/eclipse.platform.releng.aggregator/eclipse.platform.swt/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/internal/Converter.java:34: error: bad HTML entity
Error:   * About JNI & string conversion:
Error:               ^
Error:  /home/runner/work/eclipse.platform.releng.aggregator/eclipse.platform.releng.aggregator/eclipse.platform.swt/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/internal/Converter.java:53: error: bad HTML entity
Error:   * About encoding on Linux/Gtk & it's relevance to SWT:
Error:                                 ^
Error:  /home/runner/work/eclipse.platform.releng.aggregator/eclipse.platform.releng.aggregator/eclipse.platform.swt/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/internal/Converter.java:58: error: bad HTML entity
Error:   * UTF-8 = minimum is 8 bits, max is 6 bytes, but rarely goes beyond 4 bytes. Gtk & most of web uses this.
Error:                                                                                    ^
Error:  /home/runner/work/eclipse.platform.releng.aggregator/eclipse.platform.releng.aggregator/eclipse.platform.swt/bundles/org.eclipse.swt/Eclipse SWT PI/gtk/org/eclipse/swt/internal/gtk/OS.java:453: error: unknown tag: method
Error:  	/** @method flags=no_gen

And currently I have no idea why.

@laeubi
Copy link
Contributor

laeubi commented May 1, 2025

And currently I have no idea why.

& needs to be escaped as & and @method is not a valid javadoc tag

@HannesWell
Copy link
Member Author

And currently I have no idea why.

& needs to be escaped as & and @method is not a valid javadoc tag

Yes sure, I meant why this does not appear somewhere else. But I just noticed that SWT is the only project that doesn't build the javadoc in verification builds. I'm about that change that and fix all the errors in:

@HannesWell HannesWell force-pushed the add-aggregator-gh-build branch from 8ccc9fd to 0a51543 Compare May 2, 2025 08:41
@HeikoKlare
Copy link
Contributor

@HannesWell You can of course just remove my commit in this PR instead of adding a revert commit. It was just for testing purposes to work around the infrastructure issues but it turned out that one of the issues was actually a general build issue that meanwhile was fixed: eclipse-platform/eclipse.platform.swt#2077

Even though the infrastructure issues have been resolved for now, I would be in favor of contributing this workflow to be dispatched manually, so that one can trigger an aggregator build if required without waiting for the nightly I-Build. One possible extension might be to introduce a branch tag pattern to execute the workflow, such that one can for example test changes across multiple repos by changing the .gitmodules branches accordingly and then triggering the workflow proposed here on that state.

@akurtakov
Copy link
Member

What is the status of this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants