Skip to content

[Build] Don't fail shared GH-workflow on test-failures #3001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Build] Don't fail shared GH-workflow on test-failures #3001

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/mavenBuild.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ jobs:
-Dcompare-version-with-baselines.skip=false
-Pbree-libs
-Papi-check
--fail-at-end
--fail-at-end -Dmaven.test.failure.ignore=true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--fail-at-end -Dmaven.test.failure.ignore=true

As mentioned in the other PR I think we better should even remove --fail-at-end (and possibly -Pbree-libs / -Papi-check)

The workflow should just replicate the usual workflow/setup and if projects want they can set whatever option seems suitable for them (and change it without affecting others) e.g. in maven.config or with maven options specified.

Even though it might feels a bit "duplicated" it makes it much easier to run a local build with the recommended options without the need to dig into CI files to find out the desired options, and gives much more freedom.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think we must not remove that (#2998 (comment)):

This is something we cannot do as we have sporadically failing tests and people are (unfortunately) used to merging PRs with such a failure referring to the issue reporting that failure. So this could easily lead to test failure that would occur after such a known one to stay undiscovered.

${{ inputs.maven-goals }}
- name: Upload Test Results for ${{ matrix.config.name }}
if: always()
Expand Down
Loading