[Build] Remove unusable 'api-problems'-matcher for shared GH workflows #3002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@HannesWell the pattern matcher was always fragile, I therefore recommend to simply remove this entirely. We already have issues reported by Jenkins now in a much better way. |
Member
Author
|
I was hoping for a quick fix, but it looks like something more has to be done and I doubt it's worth the time now. I'll change this PR to remove the problem matcher part this evening. |
The defined pattern seems not to match and cannot easily be fixed. And because in Jenkins API-problems are displayed more reliably, the entire matcher is just removed.
HannesWell
force-pushed
the
fix-api-problem-matcher
branch
from
23e1394 to
bc93b15
Compare
HannesWell
changed the title
Member
Author
|
Updated this PR to just remove the problem-matcher along with it's download-step, as suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current api-problems matcher seems not to work anymore.
I have the impression that could be because the current pattern doesn't match the print-out, which is in the 'raw'-view
[ERROR] [API ERROR] File MANIFEST.MF at line 7: The minor version should be incremented in version 1.1.600, since new APIs have been added since version 1.1.500 (location: /home/runner/work/eclipse.platform.ui/eclipse.platform.ui/bundles/org.eclipse.e4.core.commands/META-INF/MANIFEST.MF)respectively in the 'default' view:
Error: [API ERROR] File MANIFEST.MF at line 7: The minor version should be incremented in version 1.1.600, since new APIs have been added since version 1.1.500 (location: /home/runner/work/eclipse.platform.ui/eclipse.platform.ui/bundles/org.eclipse.e4.core.commands/META-INF/MANIFEST.MF)Although the new pattern matches the different beginning of the line better, it looks like the pattern still does not match. But according to the documentation of
problem-matcherseverything else seems to be in place.That workflow run shows that the matcher is added:
https://github.com/eclipse-platform/eclipse.platform.ui/actions/runs/14694871712/job/41235517380
So probably the pattern still does not work somehow.