Skip to content

Conversation

@merks
Copy link
Contributor

@merks merks commented May 8, 2025

  • There is no need to filter out wanted content because the aggregator only aggregates what we want to publish.
  • There is no need to enrich the poms because the aggregator creates poms the meet the nexus publishing requirements and tests that the poms do actually conform.
  • There is no need to create javadoc stubs because the aggregator generates one (for every artifact with a corresponding sources.jar.
  • There is no need to recompute checksums because nothing is modified.

- There is no need to filter out wanted content because the aggregator
only aggregates what we want to publish.
- There is no need to enrich the poms because the aggregator creates
poms the meet the nexus publishing requirements and tests that the poms
do actually conform.
- There is no need to create javadoc stubs because the aggregator
generates one (for every artifact with a corresponding `sources.jar`.
- There is no need to recompute checksums because nothing is modified.
@merks
Copy link
Contributor Author

merks commented May 8, 2025

Has no build impact.

@merks merks merged commit 8190cfa into eclipse-platform:master May 8, 2025
5 of 6 checks passed
@merks merks deleted the pr-simplify-publishToMaven branch May 8, 2025 14:35
HannesWell added a commit to HannesWell/eclipse.platform.releng.aggregator that referenced this pull request May 8, 2025
And downgrade the JDK used in the publishToMaven Jenkins pipeline as we
don't need the latest Java-22/23 features anymore, i.e. the ability to
launch multi-file source-code programs.

Follow-up on
- eclipse-platform#3035
@HannesWell
Copy link
Member

Thanks a lot @merks for this work. It's really great to see how the publication to Maven-Central becomes easier and easier!

Regarding the points you mentioned I just wanted to record that they are not necessary anymore, due your enhancements in

respectively in the CBI aggregator.

HannesWell added a commit to HannesWell/eclipse.platform.releng.aggregator that referenced this pull request May 9, 2025
And downgrade the JDK used in the publishToMaven Jenkins pipeline as we
don't need the latest Java-22/23 features anymore, i.e. the ability to
launch multi-file source-code programs.

Follow-up on
- eclipse-platform#3035
HannesWell added a commit to HannesWell/eclipse.platform.releng.aggregator that referenced this pull request May 9, 2025
And downgrade the JDK used in the publishToMaven Jenkins pipeline as we
don't need the latest Java-22/23 features anymore, i.e. the ability to
launch multi-file source-code programs.

Follow-up on
- eclipse-platform#3035
HannesWell added a commit to HannesWell/eclipse.platform.releng.aggregator that referenced this pull request May 9, 2025
And downgrade the JDK used in the publishToMaven Jenkins pipeline as we
don't need the latest Java-22/23 features anymore, i.e. the ability to
launch multi-file source-code programs.

Follow-up on
- eclipse-platform#3035
HannesWell added a commit to HannesWell/eclipse.platform.releng.aggregator that referenced this pull request May 9, 2025
And downgrade the JDK used in the publishToMaven Jenkins pipeline as we
don't need the latest Java-22/23 features anymore, i.e. the ability to
launch multi-file source-code programs.

Follow-up on
- eclipse-platform#3035
HannesWell added a commit to HannesWell/eclipse.platform.releng.aggregator that referenced this pull request May 9, 2025
And downgrade the JDK used in the publishToMaven Jenkins pipeline as we
don't need the latest Java-22/23 features anymore, i.e. the ability to
launch multi-file source-code programs.

Follow-up on
- eclipse-platform#3035
HannesWell added a commit that referenced this pull request May 9, 2025
And downgrade the JDK used in the publishToMaven Jenkins pipeline as we
don't need the latest Java-22/23 features anymore, i.e. the ability to
launch multi-file source-code programs.

Follow-up on
- #3035
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants