Skip to content

Conversation

@akurtakov
Copy link
Member

All the content should still be there as materialize-products has includeSources=true property set.

All the content should still be there as materialize-products has
includeSources=true property set.
@akurtakov akurtakov requested a review from laeubi June 27, 2025 07:04
Copy link
Contributor

@laeubi laeubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes since a while we already include the sources anyways, so it is just shipping the feature itself... (so removing it will not remove any sources).

@akurtakov
Copy link
Member Author

/request-license-review

@github-actions
Copy link
Contributor

/request-license-review

⚠️ Failed to request review of not vetted licenses.

Workflow run (with attached summary files):
https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/actions/runs/15920882994

@akurtakov
Copy link
Member Author

/request-license-review

@laeubi
Copy link
Contributor

laeubi commented Jun 27, 2025

Its quite unlikley that the licenses make any problem for this change. The run says "Received an error response from ClearlyDefined." seems the service is currently down...

@akurtakov
Copy link
Member Author

I know that, also clearlydefined gives errors quite often and the previous run failed with few of our own plugins being wrongly flagged by the tool and I want to have iplab issues for them so they don't fail on other PRs.

@akurtakov
Copy link
Member Author

Anyway, merging and starting new I-build to verify state.

@akurtakov akurtakov merged commit 128af7f into eclipse-platform:master Jun 27, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants