[Build] Inline makeVisible script and simplify Make Visible job #3169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannesWell
commented
Jul 2, 2025
HannesWell
force-pushed
the
simplify-make-visible
branch
3 times, most recently
from
420844e to
71a8805
Compare
Also combine all parameters into one, which simplifies starting the job and simplifies its initialization.
HannesWell
force-pushed
the
simplify-make-visible
branch
from
71a8805 to
766e59f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally combine all parameters into one to simplify calling the job.
@MohananRahul FYI, this should further simplify the promotion process (but changes it a bit).
Follow-up on