Skip to content

Conversation

@HannesWell
Copy link
Member

@HannesWell HannesWell commented Jul 11, 2025

instead of changing the SDK4Mvn.aggr files to just run the publication job subsequently and then changing it again to the next release cycle's I-build repository.
This avoids the described changes and simplifies the release process.

@HannesWell
Copy link
Member Author

@elsazac this makes changes like #3105 unnecessary during the release process. You can just specify the p2-repository to publish by its URL as parameter when triggering the Maven-publish job.
I have also adjusted the documentation and hope this is sufficient.

@HannesWell HannesWell force-pushed the maven-publish-specific-repository branch 2 times, most recently from 409b5b3 to 6f34c37 Compare July 11, 2025 20:46
@HannesWell
Copy link
Member Author

@stephan-herrmann, this also would make it possible to deploy Y-build snapshots in a simple way, as for example requested in #2625 (comment).
Probably the only additionally required change would be specifying the target (snapshot) maven repository, as I assume that Y-build snapshots should go to another Maven-repository.

Would you be in favor of such deployment? And if yes, where should it go? The JDT eclipse-repo?

instead of changing the SDK4Mvn.aggr files to just run the publication
job subsequently and then changing it again to the next release cycle's
I-build repository.
This avoids the described changes and simplifies the release process.
@HannesWell HannesWell force-pushed the maven-publish-specific-repository branch from 6f34c37 to 0b7e443 Compare July 11, 2025 21:04
@HannesWell HannesWell merged commit a2a5ba7 into eclipse-platform:master Jul 11, 2025
3 of 6 checks passed
@HannesWell HannesWell deleted the maven-publish-specific-repository branch July 11, 2025 21:05
@HannesWell HannesWell changed the title [RelEng] Specify P2 repository to publish to Maven-Repo as job parameter [RelEng] Specify P2 repository to publish to Maven as job parameter Jul 11, 2025
@stephan-herrmann
Copy link
Contributor

@stephan-herrmann, this also would make it possible to deploy Y-build snapshots in a simple way, as for example requested in #2625 (comment). Probably the only additionally required change would be specifying the target (snapshot) maven repository, as I assume that Y-build snapshots should go to another Maven-repository.

Would you be in favor of such deployment?

I have no strong opinion either way.

IMHO deploying the entire Y-build would be too much. In the comment you quote only ecj was requested.

And if yes, where should it go? The JDT eclipse-repo?

I don't even know of any such JDT eclipse-repo :-/ -- but it might indeed be a good idea to keep Y-build artifacts separate, just in case there's an unintended overlap of versions between master an the beta branch.

@mickaelistria
Copy link
Contributor

I don't even know of any such JDT eclipse-repo :-/

See https://github.com/eclipse-jdt/eclipse.jdt.core/blob/master/pom.xml#L52 , a p2 repo is created for jdt.core if built with -Pp2-repo profile.

@stephan-herrmann
Copy link
Contributor

I don't even know of any such JDT eclipse-repo :-/

See https://github.com/eclipse-jdt/eclipse.jdt.core/blob/master/pom.xml#L52 , a p2 repo is created for jdt.core if built with -Pp2-repo profile.

This seems to answer a different question. @HannesWell asked "where should it go?", but the pom you reference doesn't show a URL where JDT can deploy maven snapshot artifacts for users to consume.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants