Skip to content

Conversation

@chrisrueger
Copy link
Contributor

@chrisrueger chrisrueger commented Aug 27, 2025

Replace pipe with comma, since pipe means "or" / choice. But that would mean you can only use one of the elements. Comma means that feature must contain the following elements, which is what we want here

I found an archived site which uses comma: https://archive.eclipse.org/eclipse/downloads/documentation/2.0/html/plugins/org.eclipse.platform.doc.isv/reference/misc/feature_archive.html

Replace pipe with comma, since pipe means "or" / choice. But that would mean you can only use one of the elements. Comman means sequence, which is what we want here
@chrisrueger chrisrueger changed the title fix DTD for feature.xml docs/help: fix DTD for feature.xml Aug 27, 2025
@chrisrueger chrisrueger changed the title docs/help: fix DTD for feature.xml docs/help: fix DTD for P2 feature.xml Aug 27, 2025
@merks
Copy link
Contributor

merks commented Aug 27, 2025

@akurtakov

I believe this change is an accurate correction according to Elements with Children (sequences) here:

https://www.w3schools.com/xml/xml_dtd_elements.asp

Given it's a doc only change, should we merge it now?

@akurtakov
Copy link
Member

Fine by me.

@merks merks merged commit 674143d into eclipse-platform:master Aug 27, 2025
5 of 6 checks passed
@merks
Copy link
Contributor

merks commented Aug 27, 2025

@chrisrueger

Thanks for the attention to details!

@chrisrueger
Copy link
Contributor Author

Thanks @merks
I stumbled over this while working on a testcase the P2Export in bnd and I wanted to add a validation of the feature.xml bnd generates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants