Skip to content

Conversation

@HeikoKlare
Copy link
Contributor

The terminal tests are missing in the I-Build tests. This change adds the according configuration.

This requires the addition of an according test.xml to the test plugin first via:

Copy link
Member

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks.

In general I think we should avoid the need for a testManifest.xml and just drive the list of expected tests dynamically.

@HeikoKlare HeikoKlare force-pushed the daily-terminaltests branch from 91454d1 to bd4a20c Compare January 5, 2026 09:20
@HeikoKlare
Copy link
Contributor Author

From my understanding, the version increment workflow fails because it is executed on the org.eclipse.releng folder, thus the build of the features in that folder consumes the included plugins from a referenced p2 repository. This will be the I-Build repository that does currently not contain the org.eclipse.terminal.test bundle (e.g. https://download.eclipse.org/eclipse/updates/4.39-I-builds/I20260104-1800/), which is why the build fails accordingly:

Cannot resolve dependencies of project eclipse.platform.releng:org.eclipse.sdk.tests:eclipse-feature:4.39.0-SNAPSHOT
Error:   with context {osgi.os=linux, osgi.ws=gtk, org.eclipse.update.install.features=true, org.eclipse.jdt.buildtime=true, osgi.arch=x86_64, org.eclipse.update.install.sources=true}
Error:    Software being installed: org.eclipse.sdk.tests.feature.group 4.39.0.qualifier
Error:    Missing requirement: org.eclipse.sdk.tests.feature.group 4.39.0.qualifier requires 'org.eclipse.equinox.p2.iu; org.eclipse.terminal.test 0.0.0' but it could not be found: See log for details

With the test bundle being included in org.eclipse.sdk.tests via this PR, it will be promoted to the I-Build's p2 repository due to the inclusion via:

<feature id="org.eclipse.sdk.tests">
<category name="org.eclipse.releng.testsIU"/>
</feature>

@HannesWell is this assessment correct, so that we can/have to ignore the version increment workflow failure here?

@HannesWell
Copy link
Member

HannesWell commented Jan 5, 2026

is this assessment correct, so that we can/have to ignore the version increment workflow failure here?

Yes that sounds plausible to me and I think we can ignore it for this.

@HannesWell HannesWell merged commit 8cc85f3 into eclipse-platform:master Jan 5, 2026
5 of 7 checks passed
@HeikoKlare HeikoKlare deleted the daily-terminaltests branch January 6, 2026 08:58
@HeikoKlare
Copy link
Contributor Author

The tests were not executed properly. If I am not mistaken, this is caused by the terminal not being part of the SDK, such that the production bundle to be tested by the added test bundle is not present in the I-Build test product. I created an issue on the topic:

@HannesWell
Copy link
Member

If I am not mistaken, this is caused by the terminal not being part of the SDK, such that the production bundle to be tested by the added test bundle is not present in the I-Build test product.

Yes, the director logs seems to confirm this:
https://download.eclipse.org/eclipse/downloads/drops4/I20260105-1800/testresults/ep439I-unit-linux-x86_64-java21_linux.gtk.x86_64_21/directorLogs/director-org.eclipse.terminal.test.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants