-
Notifications
You must be signed in to change notification settings - Fork 89
Add org.eclipse.terminal.test to daily build tests #3590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add org.eclipse.terminal.test to daily build tests #3590
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks.
In general I think we should avoid the need for a testManifest.xml and just drive the list of expected tests dynamically.
91454d1 to
bd4a20c
Compare
|
From my understanding, the version increment workflow fails because it is executed on the With the test bundle being included in eclipse.platform.releng.aggregator/sites/eclipse-platform-repository/category.xml Lines 3 to 5 in 77f4e89
@HannesWell is this assessment correct, so that we can/have to ignore the version increment workflow failure here? |
Yes that sounds plausible to me and I think we can ignore it for this. |
|
The tests were not executed properly. If I am not mistaken, this is caused by the terminal not being part of the SDK, such that the production bundle to be tested by the added test bundle is not present in the I-Build test product. I created an issue on the topic: |
Yes, the director logs seems to confirm this: |
The terminal tests are missing in the I-Build tests. This change adds the according configuration.
This requires the addition of an according
test.xmlto the test plugin first via: