Add early variable resolution in build websites to reduce flickering #3596
+89
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Especially for Stable and Release builds most interpolated data, that are prominently shown at the top of the main page, can be derived from the drop-folder's name, which is contained in the page's URL/location. Using the identifier implied by the drop-folder allows to render the page with these most prominently visible variables already resolved initially and not only on the second pass, when the buildproperties.json is fetched. Thus this reduces flickering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially for Stable and Release builds most interpolated data, that are prominently shown at the top of the main page, can be derived from the drop-folder's name, which is contained in the page's URL/location. Using the identifier implied by the drop-folder allows to render the page with these most prominently visible variables already resolved initially and not only on the second pass, when the buildproperties.json is fetched. Thus this reduces flickering.