Skip to content

Tag API leaking Windows OLE methods/fields as non-api #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+110 −116
Open

Tag API leaking Windows OLE methods/fields as non-api #1119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
99 changes: 41 additions & 58 deletions binaries/org.eclipse.swt.win32.win32.aarch64/.settings/.api_filters
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,128 +1,111 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<component id="org.eclipse.swt.win32.win32.aarch64" version="2">
<resource path="Eclipse SWT OLE Win32/win32/org/eclipse/swt/ole/win32/OleAutomation.java" type="org.eclipse.swt.ole.win32.OleAutomation">
<filter id="643842064">
<filter id="338944126">
<message_arguments>
<message_argument value="TYPEATTR"/>
<message_argument value="OleAutomation"/>
<message_argument value="org.eclipse.swt.ole.win32.OleAutomation"/>
<message_argument value="getTypeInfoAttributes()"/>
</message_arguments>
</filter>
</resource>
<resource path="Eclipse SWT OLE Win32/win32/org/eclipse/swt/ole/win32/OleClientSite.java" type="org.eclipse.swt.ole.win32.OleClientSite">
<filter id="627060751">
<filter id="338940029">
<message_arguments>
<message_argument value="GUID"/>
<message_argument value="OleClientSite"/>
<message_argument value="org.eclipse.swt.ole.win32.OleClientSite"/>
<message_argument value="appClsid"/>
</message_arguments>
</filter>
<filter id="627060751">
<filter id="338940029">
<message_arguments>
<message_argument value="IOleCommandTarget"/>
<message_argument value="OleClientSite"/>
<message_argument value="objIOleCommandTarget"/>
<message_argument value="org.eclipse.swt.ole.win32.OleClientSite"/>
<message_argument value="objDocumentView"/>
</message_arguments>
</filter>
<filter id="627060751">
<filter id="338940029">
<message_arguments>
<message_argument value="IOleDocumentView"/>
<message_argument value="OleClientSite"/>
<message_argument value="objDocumentView"/>
<message_argument value="org.eclipse.swt.ole.win32.OleClientSite"/>
<message_argument value="objIOleCommandTarget"/>
</message_arguments>
</filter>
<filter id="627060751">
<filter id="338940029">
<message_arguments>
<message_argument value="IOleInPlaceObject"/>
<message_argument value="OleClientSite"/>
<message_argument value="org.eclipse.swt.ole.win32.OleClientSite"/>
<message_argument value="objIOleInPlaceObject"/>
</message_arguments>
</filter>
<filter id="627060751">
<filter id="338940029">
<message_arguments>
<message_argument value="IOleObject"/>
<message_argument value="OleClientSite"/>
<message_argument value="org.eclipse.swt.ole.win32.OleClientSite"/>
<message_argument value="objIOleObject"/>
</message_arguments>
</filter>
<filter id="627060751">
<message_arguments>
<message_argument value="IStorage"/>
<message_argument value="OleClientSite"/>
<message_argument value="tempStorage"/>
</message_arguments>
</filter>
<filter id="627060751">
<filter id="338940029">
<message_arguments>
<message_argument value="IUnknown"/>
<message_argument value="OleClientSite"/>
<message_argument value="org.eclipse.swt.ole.win32.OleClientSite"/>
<message_argument value="objIUnknown"/>
</message_arguments>
</filter>
<filter id="627060751">
<filter id="338940029">
<message_arguments>
<message_argument value="IViewObject2"/>
<message_argument value="OleClientSite"/>
<message_argument value="org.eclipse.swt.ole.win32.OleClientSite"/>
<message_argument value="objIViewObject2"/>
</message_arguments>
</filter>
<filter id="643842064">
<filter id="338940029">
<message_arguments>
<message_argument value="GUID"/>
<message_argument value="OleClientSite"/>
<message_argument value="getClassID(String)"/>
<message_argument value="org.eclipse.swt.ole.win32.OleClientSite"/>
<message_argument value="tempStorage"/>
</message_arguments>
</filter>
<filter id="643842064">
<filter id="338944126">
<message_arguments>
<message_argument value="IStorage"/>
<message_argument value="OleClientSite"/>
<message_argument value="org.eclipse.swt.ole.win32.OleClientSite"/>
<message_argument value="createTempStorage()"/>
</message_arguments>
</filter>
<filter id="338944126">
<message_arguments>
<message_argument value="org.eclipse.swt.ole.win32.OleClientSite"/>
<message_argument value="getClassID(String)"/>
</message_arguments>
</filter>
</resource>
<resource path="Eclipse SWT OLE Win32/win32/org/eclipse/swt/ole/win32/OleControlSite.java" type="org.eclipse.swt.ole.win32.OleControlSite">
<filter id="643846161">
<filter id="338944126">
<message_arguments>
<message_argument value="GUID"/>
<message_argument value="OleControlSite"/>
<message_argument value="org.eclipse.swt.ole.win32.OleControlSite"/>
<message_argument value="getLicenseInfo(GUID)"/>
</message_arguments>
</filter>
<filter id="643846161">
<filter id="338944126">
<message_arguments>
<message_argument value="GUID"/>
<message_argument value="OleControlSite"/>
<message_argument value="org.eclipse.swt.ole.win32.OleControlSite"/>
<message_argument value="removeEventListener(OleAutomation, GUID, int, OleListener)"/>
</message_arguments>
</filter>
</resource>
<resource path="Eclipse SWT OLE Win32/win32/org/eclipse/swt/ole/win32/Variant.java" type="org.eclipse.swt.ole.win32.Variant">
<filter id="643842064">
<filter id="338944126">
<message_arguments>
<message_argument value="IDispatch"/>
<message_argument value="Variant"/>
<message_argument value="org.eclipse.swt.ole.win32.Variant"/>
<message_argument value="getDispatch()"/>
</message_arguments>
</filter>
<filter id="643842064">
<filter id="338944126">
<message_arguments>
<message_argument value="IUnknown"/>
<message_argument value="Variant"/>
<message_argument value="org.eclipse.swt.ole.win32.Variant"/>
<message_argument value="getUnknown()"/>
</message_arguments>
</filter>
<filter id="643850349">
<filter id="338948223">
<message_arguments>
<message_argument value="IDispatch"/>
<message_argument value="Variant"/>
<message_argument value="org.eclipse.swt.ole.win32.Variant"/>
<message_argument value="Variant(IDispatch)"/>
</message_arguments>
</filter>
<filter id="643850349">
<filter id="338948223">
<message_arguments>
<message_argument value="IUnknown"/>
<message_argument value="Variant"/>
<message_argument value="org.eclipse.swt.ole.win32.Variant"/>
<message_argument value="Variant(IUnknown)"/>
</message_arguments>
</filter>
Expand Down
99 changes: 41 additions & 58 deletions binaries/org.eclipse.swt.win32.win32.x86_64/.settings/.api_filters
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,128 +1,111 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<component id="org.eclipse.swt.win32.win32.x86_64" version="2">
<resource path="Eclipse SWT OLE Win32/win32/org/eclipse/swt/ole/win32/OleAutomation.java" type="org.eclipse.swt.ole.win32.OleAutomation">
<filter id="643842064">
<filter id="338944126">
<message_arguments>
<message_argument value="TYPEATTR"/>
<message_argument value="OleAutomation"/>
<message_argument value="org.eclipse.swt.ole.win32.OleAutomation"/>
<message_argument value="getTypeInfoAttributes()"/>
</message_arguments>
</filter>
</resource>
<resource path="Eclipse SWT OLE Win32/win32/org/eclipse/swt/ole/win32/OleClientSite.java" type="org.eclipse.swt.ole.win32.OleClientSite">
<filter id="627060751">
<filter id="338940029">
<message_arguments>
<message_argument value="GUID"/>
<message_argument value="OleClientSite"/>
<message_argument value="org.eclipse.swt.ole.win32.OleClientSite"/>
<message_argument value="appClsid"/>
</message_arguments>
</filter>
<filter id="627060751">
<filter id="338940029">
<message_arguments>
<message_argument value="IOleCommandTarget"/>
<message_argument value="OleClientSite"/>
<message_argument value="objIOleCommandTarget"/>
<message_argument value="org.eclipse.swt.ole.win32.OleClientSite"/>
<message_argument value="objDocumentView"/>
</message_arguments>
</filter>
<filter id="627060751">
<filter id="338940029">
<message_arguments>
<message_argument value="IOleDocumentView"/>
<message_argument value="OleClientSite"/>
<message_argument value="objDocumentView"/>
<message_argument value="org.eclipse.swt.ole.win32.OleClientSite"/>
<message_argument value="objIOleCommandTarget"/>
</message_arguments>
</filter>
<filter id="627060751">
<filter id="338940029">
<message_arguments>
<message_argument value="IOleInPlaceObject"/>
<message_argument value="OleClientSite"/>
<message_argument value="org.eclipse.swt.ole.win32.OleClientSite"/>
<message_argument value="objIOleInPlaceObject"/>
</message_arguments>
</filter>
<filter id="627060751">
<filter id="338940029">
<message_arguments>
<message_argument value="IOleObject"/>
<message_argument value="OleClientSite"/>
<message_argument value="org.eclipse.swt.ole.win32.OleClientSite"/>
<message_argument value="objIOleObject"/>
</message_arguments>
</filter>
<filter id="627060751">
<message_arguments>
<message_argument value="IStorage"/>
<message_argument value="OleClientSite"/>
<message_argument value="tempStorage"/>
</message_arguments>
</filter>
<filter id="627060751">
<filter id="338940029">
<message_arguments>
<message_argument value="IUnknown"/>
<message_argument value="OleClientSite"/>
<message_argument value="org.eclipse.swt.ole.win32.OleClientSite"/>
<message_argument value="objIUnknown"/>
</message_arguments>
</filter>
<filter id="627060751">
<filter id="338940029">
<message_arguments>
<message_argument value="IViewObject2"/>
<message_argument value="OleClientSite"/>
<message_argument value="org.eclipse.swt.ole.win32.OleClientSite"/>
<message_argument value="objIViewObject2"/>
</message_arguments>
</filter>
<filter id="643842064">
<filter id="338940029">
<message_arguments>
<message_argument value="GUID"/>
<message_argument value="OleClientSite"/>
<message_argument value="getClassID(String)"/>
<message_argument value="org.eclipse.swt.ole.win32.OleClientSite"/>
<message_argument value="tempStorage"/>
</message_arguments>
</filter>
<filter id="643842064">
<filter id="338944126">
<message_arguments>
<message_argument value="IStorage"/>
<message_argument value="OleClientSite"/>
<message_argument value="org.eclipse.swt.ole.win32.OleClientSite"/>
<message_argument value="createTempStorage()"/>
</message_arguments>
</filter>
<filter id="338944126">
<message_arguments>
<message_argument value="org.eclipse.swt.ole.win32.OleClientSite"/>
<message_argument value="getClassID(String)"/>
</message_arguments>
</filter>
</resource>
<resource path="Eclipse SWT OLE Win32/win32/org/eclipse/swt/ole/win32/OleControlSite.java" type="org.eclipse.swt.ole.win32.OleControlSite">
<filter id="643846161">
<filter id="338944126">
<message_arguments>
<message_argument value="GUID"/>
<message_argument value="OleControlSite"/>
<message_argument value="org.eclipse.swt.ole.win32.OleControlSite"/>
<message_argument value="getLicenseInfo(GUID)"/>
</message_arguments>
</filter>
<filter id="643846161">
<filter id="338944126">
<message_arguments>
<message_argument value="GUID"/>
<message_argument value="OleControlSite"/>
<message_argument value="org.eclipse.swt.ole.win32.OleControlSite"/>
<message_argument value="removeEventListener(OleAutomation, GUID, int, OleListener)"/>
</message_arguments>
</filter>
</resource>
<resource path="Eclipse SWT OLE Win32/win32/org/eclipse/swt/ole/win32/Variant.java" type="org.eclipse.swt.ole.win32.Variant">
<filter id="643842064">
<filter id="338944126">
<message_arguments>
<message_argument value="IDispatch"/>
<message_argument value="Variant"/>
<message_argument value="org.eclipse.swt.ole.win32.Variant"/>
<message_argument value="getDispatch()"/>
</message_arguments>
</filter>
<filter id="643842064">
<filter id="338944126">
<message_arguments>
<message_argument value="IUnknown"/>
<message_argument value="Variant"/>
<message_argument value="org.eclipse.swt.ole.win32.Variant"/>
<message_argument value="getUnknown()"/>
</message_arguments>
</filter>
<filter id="643850349">
<filter id="338948223">
<message_arguments>
<message_argument value="IDispatch"/>
<message_argument value="Variant"/>
<message_argument value="org.eclipse.swt.ole.win32.Variant"/>
<message_argument value="Variant(IDispatch)"/>
</message_arguments>
</filter>
<filter id="643850349">
<filter id="338948223">
<message_arguments>
<message_argument value="IUnknown"/>
<message_argument value="Variant"/>
<message_argument value="org.eclipse.swt.ole.win32.Variant"/>
<message_argument value="Variant(IUnknown)"/>
</message_arguments>
</filter>
Expand Down
1 change: 1 addition & 0 deletions .../org.eclipse.swt/Eclipse SWT OLE Win32/win32/org/eclipse/swt/ole/win32/OleAutomation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,7 @@ public OleFunctionDescription getFunctionDescription(int index) {
* the member descriptions and attributes of the type.
*
* @return the type info of the receiver
* @noreference This method is not intended to be referenced by clients.
*/
public TYPEATTR getTypeInfoAttributes() {
if (objITypeInfo == null) return null;
Expand Down
Loading
Loading