[win] De-register resources with zoom support from device #1565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test Results 483 files ±0 483 suites ±0 8m 26s ⏱️ +7s For more details on these failures, see this check. Results for commit a9d64a8. ± Comparison against base commit 5d67ce6. ♻️ This comment has been updated with latest results. |
fedejeanne
approved these changes
Oct 30, 2024
HeikoKlare
force-pushed
the
deregister-resources
branch
from
96190c3 to
893479d
Compare
Contributor
|
Looks good to me |
Resources with zoom support are registered at their device so that handles for zoom levels that are not necessary anymore can be disposed. When these resources are destroyed, they are currently not de-registered form their device, potentially leading to resource leaks. This change makes the resources de-register themselves form their device when being destroyed. Supplements eclipse-platform#1477
HeikoKlare
force-pushed
the
deregister-resources
branch
from
893479d to
a9d64a8
Compare
HeikoKlare
changed the title
Contributor
Author
|
Failing tests are Linux-specific and documented: #1564 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resources with zoom support are registered at their device so that handles for zoom levels that are not necessary anymore can be disposed. When these resources are destroyed, they are currently not de-registered form their device, potentially leading to resource leaks. This change makes the resources de-register themselves form their device when being destroyed.
Fixes regression from:
Fixes eclipse-jdt/eclipse.jdt.ui#1752