Skip to content

Conversation

@HeikoKlare
Copy link
Contributor

This enhances the readme in the following ways:

  • Use consistent markdown formatting throughout the document and change all headlines to title case
  • Add a section on prototyping work for a single, OS-agnostic SWT implementation with links to the according prototype repositories (Initiative 31)

Fixes #1580

@HeikoKlare HeikoKlare requested a review from vogella November 18, 2024 16:00
@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2024

Test Results

   483 files  ±0     483 suites  ±0   8m 43s ⏱️ - 3m 51s
 4 095 tests ±0   4 085 ✅ ±0   7 💤 ±0  3 ❌ ±0 
16 173 runs  ±0  16 080 ✅ ±0  90 💤 ±0  3 ❌ ±0 

For more details on these failures, see this check.

Results for commit e8fc11b. ± Comparison against base commit e6588c2.

♻️ This comment has been updated with latest results.

@vogella
Copy link
Contributor

vogella commented Nov 18, 2024

LGTM, I personally would have split the new header styling from the new text but having it together is also fine for me.

@vogella
Copy link
Contributor

vogella commented Nov 18, 2024

In the Skia link it points to https://github.com/JetBrains/skija which says it is not maintained anymore,

This enhances the readme by using consistent markdown formatting
throughout the document and changing all headlines to title case
…#1580

This enhances the readme by adding a section on prototyping work for a
single, OS-agnostic SWT implementation with links to the according
prototype repositories (Initiative 31).

Fixes eclipse-platform#1580
@HeikoKlare
Copy link
Contributor Author

In the Skia link it points to https://github.com/JetBrains/skija which says it is not maintained anymore,

Thank you! I have adapted the link to refer to the current Skija implementation (which has been forked out of the linked one).

I personally would have split the new header styling from the new text but having it together is also fine for me.

Agreed. I have now at least split up the commit into two.

@akurtakov
Copy link
Member

Merging this one.

@akurtakov akurtakov merged commit 6ab4ccd into eclipse-platform:master Nov 27, 2024
9 of 14 checks passed
@HeikoKlare HeikoKlare deleted the readme-initiative31 branch January 2, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add information about SWT experimental work to README

3 participants