[win32] No handle creation on Image::getBounds #1643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adapts the bounds calculation in Image to not create any handle, but use and scale the bounds of an existing handle if no handle for the desired zoom is available Fixes eclipse-platform#1639
Contributor
HeikoKlare
reviewed
Dec 10, 2024
Contributor
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
The change looks good to me.
@tobiasmelcher may I ask you to validate whether this is a proper fix for #1639?
tobiasmelcher
approved these changes
Dec 10, 2024
Contributor
tobiasmelcher
left a comment
tobiasmelcher
left a comment
There was a problem hiding this comment.
fix works fine in our scenario. "Graphic is disposed" SWTException is no longer thrown.
Contributor
|
Thank you for the quick validation! Test failures are unrelated and documented: |
akoch-yatta
deleted the
prevent-handle-creation-on-image-bounds-calculation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adapts the bounds calculation in Image to not create any handle, but use and scale the bounds of an existing handle if no handle for the desired zoom is available
Fixes #1639