Skip to content

Conversation

@akoch-yatta
Copy link
Contributor

This commit adresses possibly invalid result when using Region::intersects on a zoom not dividable by 100. Reason is that scaling up all attributes of the rectangle separately can lead to rounding errors. Scaling them together as a rectangle solves this limitation.

This commit adresses possibly invalid result when using Region::intersects
on a zoom not dividable by 100. Reason is that scaling up all attributes of
the rectangle separately can lead to rounding errors. Scaling
them together as a rectangle solves this limitation.
@github-actions
Copy link
Contributor

Test Results

   494 files  ±0     494 suites  ±0   8m 28s ⏱️ -53s
 4 332 tests +1   4 319 ✅ +1   13 💤 ±0  0 ❌ ±0 
16 573 runs  +1  16 465 ✅ +1  108 💤 ±0  0 ❌ ±0 

Results for commit 3cc2e94. ± Comparison against base commit 56767ec.

Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is part of completing a fix in 2016 (3b55f60) improving the initial HiDPI support (e02d49a) for fractional scale values, which was only applied to according calculations in DPIUtil but not to all consumers that contained the same inaccuracy.

@HeikoKlare HeikoKlare merged commit 5c11f0b into eclipse-platform:master Jan 27, 2025
14 checks passed
@HeikoKlare HeikoKlare deleted the fix-scaling-rectangle-region-intersects branch January 27, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants