Skip to content

[Win32] Add missing releases of queried WebView interfaces #1772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HeikoKlare merged 1 commit into from
Jan 28, 2025
Merged

[Win32] Add missing releases of queried WebView interfaces #1772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion bundles/org.eclipse.swt/Eclipse SWT Browser/win32/org/eclipse/swt/browser/Edge.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ ICoreWebView2 initializeWebView(ICoreWebView2Controller controller) {
webViewWrapper.webView_10 = initializeWebView_10(webView);
webViewWrapper.webView_11 = initializeWebView_11(webView);
webViewWrapper.webView_12 = initializeWebView_12(webView);
webViewWrapper.webView_13= initializeWebView_13(webView);
webViewWrapper.webView_13 = initializeWebView_13(webView);
webViewWrapperFuture.complete(webViewWrapper);
return webView;
}
Expand Down Expand Up @@ -744,8 +744,10 @@ void browserDispose(Event event) {
if (environment2 != null) environment2.Release();
if (settings != null) settings.Release();
if (webViewProvider.isWebView_2Available()) webViewProvider.getWebView_2(false).Release();
if (webViewProvider.isWebView_10Available()) webViewProvider.getWebView_10(false).Release();
if (webViewProvider.isWebView_11Available()) webViewProvider.getWebView_11(false).Release();
if (webViewProvider.isWebView_12Available()) webViewProvider.getWebView_12(false).Release();
if (webViewProvider.isWebView_13Available()) webViewProvider.getWebView_13(false).Release();
if(controller != null) {
// Bug in WebView2. Closing the controller from an event handler results
// in a crash. The fix is to delay the closure with asyncExec.
Expand Down
Loading