[Win32] Add OS result to failing Edge initialization after retries #1779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
The Edge implementation contains retry functionality according to the ICoreWebView2Environment documentation. After five retries, the initialization is aborted with an error. In order to ease debugging of potential causes, this change adds the OS result of the last retry attempt to the error logged by the initialization abortion.
HeikoKlare
force-pushed
the
edge_retry_result_in_error
branch
from
702901d to
5f6e876
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Edge implementation contains retry functionality according to the ICoreWebView2Environment documentation. After five retries, the initialization is aborted with an error.
In order to ease debugging of potential causes, this change adds the OS result of the last retry attempt to the error logged by the initialization abortion.