Simplify scaling of ImageData with DPIUtil #1867
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HeikoKlare
reviewed
Feb 28, 2025
Contributor
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
Thank you for this cleanup! There is not greater plan for that method and it is obviously obsolete in it's current state. Maybe it was different at some point in time.
Member
Author
|
With the current state of #1828, I think the method to be removed here gets a revival. So this should at least be delayed until that PR is completed and then we can close or submit this based on the resulting content. |
Contributor
|
Hannes, I have created #1887 with a slightly more "correct" replacement (as we should replace autoScale* calls with scale* calls on Windows) and added you as co-author there. I Thus closing this one as superceded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapping an
ImageDataobject and its zoom into aElementAtZoomobject just to unwrap it seems to be unnecessary.Or is this part of a greater plan @akoch-yatta or @HeikoKlare?