[win32] Dynamic handle creation for Path #1869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test Results 509 files + 4 509 suites +4 9m 49s ⏱️ + 1m 4s For more details on these failures, see this check. Results for commit c14992c. ± Comparison against base commit 326658a. ♻️ This comment has been updated with latest results. |
amartya4256
reviewed
Mar 6, 2025
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Path.java
Show resolved
Hide resolved
akoch-yatta
force-pushed
the
win32-refactor-path-dynamic
branch
3 times, most recently
from
fcb1337 to
6c85c4c
Compare
HeikoKlare
reviewed
Mar 10, 2025
Contributor
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
Some comments or points for discussion on the overall design. I will test the change after we have resolved them.
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Path.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Path.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Path.java
Show resolved
Hide resolved
akoch-yatta
force-pushed
the
win32-refactor-path-dynamic
branch
4 times, most recently
from
c66018b to
0d694a0
Compare
This commit adapts Path in the win32 implementation to create handles only on demand. If a non-handle specific operation like getBounds() is called, a temporary handle will be created and disposed afterwards if no handle exists already.
HeikoKlare
force-pushed
the
win32-refactor-path-dynamic
branch
from
0d694a0 to
c14992c
Compare
HeikoKlare
approved these changes
Mar 11, 2025
Contributor
|
Failing test is unrelated and documented: #1843 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adapts Path in the win32 implementation to create handles only on demand. If a non-handle specific operation like getBounds() is called, a temporary handle will be created and disposed afterwards if no handle exists already.
It contains the branch used for #1856 and is a second refactoring on transform, there it must be merged after #1856