Skip to content

Remove obsolete hashCode/equals for Region #1880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2025
+6 −14
Merged

Remove obsolete hashCode/equals for Region #1880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions bundles/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/graphics/Region.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,9 +436,7 @@ void destroy() {
*/
@Override
public boolean equals(Object object) {
if (this == object) return true;
if (!(object instanceof Region region)) return false;
return handle == region.handle;
return super.equals(object);
}

/**
Expand Down Expand Up @@ -511,7 +509,7 @@ long regionToRects(long message, long rgn, long r, long path) {
*/
@Override
public int hashCode() {
return (int)handle;
return super.hashCode();
}

/**
Expand Down
7 changes: 2 additions & 5 deletions bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/graphics/Region.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,10 +310,7 @@ void destroy() {
*/
@Override
public boolean equals(Object object) {
if (this == object) return true;
if (!(object instanceof Region)) return false;
Region region = (Region)object;
return handle == region.handle;
return super.equals(object);
}

/**
Expand Down Expand Up @@ -371,7 +368,7 @@ public static Region gtk_new(Device device, long handle) {
*/
@Override
public int hashCode() {
return (int)handle;
return super.hashCode();
}

/**
Expand Down
7 changes: 2 additions & 5 deletions bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Region.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,10 +253,7 @@ void destroyHandlesExcept(Set<Integer> zoomLevels) {
*/
@Override
public boolean equals (Object object) {
if (this == object) return true;
if (!(object instanceof Region)) return false;
Region rgn = (Region)object;
return getHandleForInitialZoom() == rgn.getHandleForInitialZoom();
return super.equals(object);
}

/**
Expand Down Expand Up @@ -295,7 +292,7 @@ Rectangle getBoundsInPixels() {
*/
@Override
public int hashCode () {
return (int)getHandleForInitialZoom();
return super.hashCode();
}

/**
Expand Down
Loading