Remove MonitorAwarePoint and restore simple equality for geometry
#1904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cific `MultiZoomCoordinateSystemMapper`.
…ith monitor-specific transformations.
Contributor
|
I added my comment on why this will not work to the preceeding discussion: #1711 (comment) |
fedejeanne
reviewed
Mar 13, 2025
| public Rectangle translateFromDisplayCoordinates(Rectangle rect, int zoom) { | ||
| Monitor monitor = rect instanceof MonitorAwareRectangle monitorAwareRect ? monitorAwareRect.getMonitor() : null; | ||
| return translateRectangleInPixelsToPoints(rect.x, rect.y, rect.width, rect.height, monitor); | ||
| Monitor monitor = null; |
Member
There was a problem hiding this comment.
Here's where you loose the information about the monitor that the MonitorAwareRectangle had, which breaks the whole thing. Same for translateToDisplayCoordinates(Point, int)
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MonitorAwarePointa windows-specific implementation detail #1903