[win32] refactor Image::init with ImageData #1906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
akoch-yatta
force-pushed
the
refactor-init-with-imagedata
branch
2 times, most recently
from
9cd2005 to
441647e
Compare
This commit refactors Image#init for ImageData in the win32 implementation. Currently this method serves two purposes. Creating handles for the given ImageData or additionally initializing an image with those handles. This two use cases are made more explicit refactoring this logic out into concrete methods.
akoch-yatta
force-pushed
the
refactor-init-with-imagedata
branch
from
441647e to
55c2e18
Compare
HeikoKlare
approved these changes
Mar 14, 2025
Contributor
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
This is a nice improvement as it disentagles multiple concerns implemented in one method and allows to explicitly call more specific methods at consumers. I traced every possible flow through the effected code to compare old and new implementation (and have to admit that it's rather difficult to follow all the flows) and can confirm that I did not find any difference before/after. I also tested an SDK with the change and found everything to work fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors Image#init for ImageData in the win32 implementation. Currently this method serves two purposes:
These two use cases are made more explicit refactoring this logic out into concrete methods. This is a necessary refactoring to be able to create all OS handles on demand and create temporary OS handles if neede.