Skip to content

[win32] Create Pattern handles on demand #1907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2025
Merged

[win32] Create Pattern handles on demand #1907

merged 1 commit into from
Mar 17, 2025

Conversation

@akoch-yatta
Copy link
Contributor

@akoch-yatta akoch-yatta commented Mar 14, 2025

This PR refactors Pattern in the win32 implementation to better support multiple handles for different zoom settings by creating all handles only on demand.

@akoch-yatta akoch-yatta linked an issue Mar 14, 2025 that may be closed by this pull request
Refactor Pattern to support creation handles on demand vi-eclipse/Eclipse-Platform#260
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2025 •
edited
Loading

Test Results

   509 files   -  1     509 suites   - 1   9m 4s ⏱️ + 1m 39s
 4 308 tests  - 37   4 296 ✅  - 35   11 💤  - 3  1 ❌ +1 
16 576 runs   - 37  16 467 ✅  - 35  108 💤  - 3  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 0bc2ca2. ± Comparison against base commit 0768d7e.

This pull request removes 37 tests. 
org.eclipse.swt.graphics.ImageWin32Tests ‑ testImageDataForDifferentFractionalZoomsShouldBeDifferent
org.eclipse.swt.graphics.ImageWin32Tests ‑ testImageShouldHaveDimesionAsPerZoomLevel
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testByteArrayTransfer
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testFileTransfer
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testHtmlTransfer
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromCopiedImage
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImage
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImageData
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImageDataFromImage
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testRtfTransfer
…

♻️ This comment has been updated with latest results.

@akoch-yatta akoch-yatta force-pushed the win32-refactor-pattern branch from 41dedbe to 70f562b Compare March 14, 2025 13:33
HeikoKlare
HeikoKlare approved these changes Mar 14, 2025
View reviewed changes
Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@fedejeanne can you please have a second look?

@HeikoKlare HeikoKlare requested a review from fedejeanne March 14, 2025 16:33
fedejeanne
fedejeanne reviewed Mar 17, 2025
View reviewed changes
Copy link
Member

@fedejeanne fedejeanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine (just some minor tweaks needed) but I haven't tested it yet since I'm on my Mac. I'll take a deeper look this evening.

@akoch-yatta
[win32] Create Pattern handles on demand
0bc2ca2 
This commit refactors Pattern in the win32 implementation to better
support multiple handles for different zoom settings by creating all
handles only on demand.
@akoch-yatta akoch-yatta force-pushed the win32-refactor-pattern branch from 70f562b to 0bc2ca2 Compare March 17, 2025 10:52
fedejeanne
fedejeanne approved these changes Mar 17, 2025
View reviewed changes
Copy link
Member

@fedejeanne fedejeanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I tested with the GraphicsExample and also with PatternWin32ManualTest and I saw no visual changes ✔️

@fedejeanne fedejeanne merged commit de99b2d into eclipse-platform:master Mar 17, 2025
12 of 14 checks passed
@fedejeanne fedejeanne deleted the win32-refactor-pattern branch March 17, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HeikoKlare HeikoKlare HeikoKlare approved these changes

@fedejeanne fedejeanne fedejeanne approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor Pattern to support creation handles on demand

3 participants

@akoch-yatta @HeikoKlare @fedejeanne