Fix NPE #1929 #1956
Merged
Fix NPE #1929 #1956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fixup for ab1d119 The contract of `openDialog()` is to throw on error, and return Optional of user action. Null return value is not expected.
Contributor
Author
|
@HeikoKlare hello, could you please take a look? |
Contributor
HeikoKlare
approved these changes
Mar 27, 2025
Contributor
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
Totally makes sense to me. Thanks for the catch and for fixing it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fixup for ab1d119.
The contract of
openDialog()is to throw on error, and return anOptionalon user action. Null return value is not expected.This does not fix the issue #1929, but fixes the error reporting per #1026