Skip to content

Conversation

@merks
Copy link
Contributor

@merks merks commented May 2, 2025

@merks
Copy link
Contributor Author

merks commented May 2, 2025

@iloveeclipse @akurtakov

Is it okay to force all fragments and the host? It seems to me these all always have the same qualifier in the repository:

image

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2025

Test Results

   539 files  ±0     539 suites  ±0   27m 50s ⏱️ - 1m 12s
 4 337 tests ±0   4 321 ✅ +1   15 💤 ±0  1 ❌  - 1 
16 601 runs  ±0  16 463 ✅ +1  137 💤 ±0  1 ❌  - 1 

For more details on these failures, see this check.

Results for commit e89a3ae. ± Comparison against base commit 8efc599.

@merks
Copy link
Contributor Author

merks commented May 2, 2025

@iloveeclipse @akurtakov @MohananRahul

The build failures are unrelated. Note that once I complete the Orbit milestone build and contribute it to the Platform's TP, I will merge this PR if there is no feedback in the meantime.

@akurtakov
Copy link
Member

I was AFK . Forcing them all wouldn't hurt.

@akurtakov
Copy link
Member

Merging as the test failure is unstable windows test.

@akurtakov akurtakov merged commit 5c5eae1 into eclipse-platform:master May 2, 2025
15 of 17 checks passed
@merks merks deleted the issue-3011 branch May 2, 2025 07:46
@HannesWell
Copy link
Member

Is it okay to force all fragments and the host? It seems to me these all always have the same qualifier in the repository:

Yes the native fragments always have the same qualifier as their host and it's sufficient to only touch the latter, due to:

<timestampProvider>fragment-host</timestampProvider>

which was configured via

@merks
Copy link
Contributor Author

merks commented May 2, 2025

I see. So for future reference, no SWT native fragment ever needs to be qualifier forced, only the host might need to be qualifier forced. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants