MenuItem (GTK): allow additional shortcut words #1852

[tmssngr]

This allows to use more shortcuts to be displayed for a menu item, e.g. Ctrl+Keypad + or Alt+Down.

[github-actions]

Test Results

   539 files  ±0     539 suites  ±0   28m 39s ⏱️ - 5m 51s
 4 364 tests ±0   4 348 ✅ ±0   15 💤 ±0  0 ❌ ±0  1 🔥 ±0 
16 691 runs  ±0  16 553 ✅ ±0  137 💤 ±0  0 ❌ ±0  1 🔥 ±0 

For more details on these errors, see this check.

Results for commit fe6e0f0. ± Comparison against base commit 7ad8ef2.

♻️ This comment has been updated with latest results.

[tmssngr]

@akurtakov Would you like to review this PR?

[akurtakov]

We are past final build for rc1. I will review it when next cycle opens.

[akurtakov]

It would be nice to have a test for these.

eclipse.platform.swt/tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_widgets_MenuItem.java

Line 262 in 7add671

public void test_setTextLjava_lang_String() {

looks like the place to add them.

[akurtakov]

A new test method might be good too(depends on how big it the test will be).

[akurtakov]

#2240 makes the test slightly more straightforward.

[tmssngr]

Yes, a test would be fine. Do you suggest to make MenuItem.MaskKeysym and getMaskKeysym more visible to test it?

[akurtakov]

My bad. Opening more for testing shouldn't happen. I'll merge the patch as is. Thanks!