[Win32] Initialize copied image provider wrapper on correct image #2188

[HeikoKlare]

When copying an image based on an input stream, the copied provider wrapper was erroneously created on the original image. This change adapts the instantiation to create the warpper on the correct image.

Fixes #2188

[akoch-yatta]

That was obviously a bug, as the copy must be based on the passed image, as it is done in the other wrappers. Tested it with the snippet from the issue this PR fixes and works as expected.

[github-actions]

Test Results

   545 files  + 6     545 suites  +6   28m 46s ⏱️ - 1m 25s
 4 399 tests +38   4 381 ✅ +36   18 💤 +3  0 ❌  - 1 
16 723 runs  +41  16 582 ✅ +39  141 💤 +3  0 ❌  - 1 

Results for commit fa69976. ± Comparison against base commit 925a294.

[merks]

A very simple fix to implement exactly what’s intended along with a test case. Very good.

+1 from the PMC for merging

[HeikoKlare]

For the record: this was obviously a sloppy mistake

• All other introduced image provider wrappers create their copy on the new image that is passed as intended, so this just aligns the one faulty provider with the others
• There is a reproducing snippet and test case demonstrating the regression and the appropriateness of the fix

To avoid that we face the regression in the upcoming release, this fix needs to go in master before the release (so for RC2).

Thank you @merks for already giving your +1!

[HeikoKlare]

And many thanks again to @estepper for reporting the issue with a great reproducer early enough to be fixed for the upcoming release ❤️

[estepper]

A pleasure! I'm happy to see the fix going into the release. Thanks for your prompt action ;-)