Skip to content

[GTK] Fix Gtk4 test crash in Control.setRegion #2218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025
Merged

[GTK] Fix Gtk4 test crash in Control.setRegion #2218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Control.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1394,6 +1394,11 @@ public void setRegion (Region region) {
long topHandle = topHandle ();

if (OS.G_OBJECT_TYPE(topHandle) == GTK.GTK_TYPE_WINDOW()) {
if (GTK.GTK4) {
//TODO gtk_widget_shape_combine_region is removed and one has to hook at the rendering layer as per
// https://gitlab.gnome.org/GNOME/gtk/-/commit/0ce19eed083c79c5fb4091db3ecaf528346e610f
return;
}
GTK3.gtk_widget_shape_combine_region(topHandle, shape_region);
/*
* Bug in GTK: on Wayland, pixels in window outside shape_region
Expand Down
Loading