Skip to content

Use the existing image to initialize the GC in ImageGcDrawerWrapper #2238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Use the existing image to initialize the GC in ImageGcDrawerWrapper #2238

wants to merge 3 commits into from

Conversation

@ShahzaibIbrahim
Copy link
Contributor

@ShahzaibIbrahim ShahzaibIbrahim commented Jun 16, 2025

In ImageGCDrawerWrapper#newImageHandle, we create a new image with existing data to initialize the GC, instead we could use the existing image object and the base handle should be created as it is done in PlainImageDataProvider.

@ShahzaibIbrahim ShahzaibIbrahim linked an issue Jun 16, 2025 that may be closed by this pull request
Use the existing image to initialize the GC in ImageGcDrawerWrapper vi-eclipse/Eclipse-Platform#328
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2025 •
edited
Loading

Test Results

  115 files   -    431    115 suites   - 431   9m 49s ⏱️ - 22m 27s
4 395 tests  -     36  4 372 ✅  -     42  15 💤  -   2  4 ❌ +4  4 🔥 +4 
  279 runs   - 16 485    272 ✅  - 16 365   3 💤  - 124  4 ❌ +4 

For more details on these failures and errors, see this check.

Results for commit 01ddea2. ± Comparison against base commit 508ad4a.

This pull request removes 37 and adds 1 tests. Note that renamed tests count towards both. 
AllGTKTests Test_GtkConverter ‑ test_HeuristicASCII_dollarSign
AllGTKTests Test_GtkConverter ‑ test_HeuristicASCII_emptyString
AllGTKTests Test_GtkConverter ‑ test_HeuristicASCII_letterA
AllGTKTests Test_GtkConverter ‑ test_HeuristicASCII_letters
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16LE_null
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_AsciiLetters
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_Asciiletter
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_LotsOfLetters
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_letter
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_letters
…

org.eclipse.swt.tests.junit.Test_org_eclipse_swt_graphics_GC ‑ test_noMemoryLeakAfterDispose

♻️ This comment has been updated with latest results.

HeikoKlare
HeikoKlare reviewed Jun 16, 2025
View reviewed changes
Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the behavior with the LineNumberRuler and that seems to be work fine with different zooms. But with this change we will see the following warnings when strict checks are enabled, which need to be resolved:

***WARNING: Images with handles created for multiple zooms should not be modified.  It should be created with an ImageGcDrawer (see SWT Snippet 384).

@HeikoKlare
Copy link
Contributor

HeikoKlare commented Jun 16, 2025

Is this something we can only do for the Windows implementation or may we adapt all the MacOS and Linux implementations of Image as well?

@ShahzaibIbrahim
Copy link
Contributor Author

ShahzaibIbrahim commented Jun 18, 2025

***WARNING: Images with handles created for multiple zooms should not be modified. It should be created with an ImageGcDrawer (see SWT Snippet 384).

This error should go away once this PR is merged.

@ShahzaibIbrahim
Copy link
Contributor Author

ShahzaibIbrahim commented Jun 18, 2025

Is this something we can only do for the Windows implementation or may we adapt all the MacOS and Linux implementations of Image as well?

Yes, it make sense to adapt the MacOS and Linux implementation of Image. But since I can't test the changes, I will wait until @fedejeanne is back and can test those changes with him.

@ShahzaibIbrahim ShahzaibIbrahim force-pushed the master-328 branch 7 times, most recently from 099e31c to d96e9ef Compare August 13, 2025 07:52
@HeikoKlare HeikoKlare mentioned this pull request Sep 14, 2025
Closed
@ShahzaibIbrahim
Use the existing image to initialize the GC in ImageGcDrawerWrapper
abc68c9 
For Windows, In ImageGCDrawerWrapper#newImageHandle, we create a new image with
existing data to initialize the GC, instead we could use the existing
image object and the base handle should be created as it is done in
PlainImageDataProvider.

For GTK and Cocoa, We use init methods to create new handles instead of creating a new Image object.
@ShahzaibIbrahim
Copy link
Contributor Author

ShahzaibIbrahim commented Sep 24, 2025

Closing this PR as removing temporary images does not reduce resource usage; handles still need to be created and disposed. A larger refactoring would be required to address this properly. More info here: vi-eclipse/Eclipse-Platform#328 (comment)

@ShahzaibIbrahim ShahzaibIbrahim deleted the master-328 branch October 27, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HeikoKlare HeikoKlare HeikoKlare left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use the existing image to initialize the GC in ImageGcDrawerWrapper

2 participants

@ShahzaibIbrahim @HeikoKlare