Skip to content

Conversation

@HannesWell
Copy link
Member

Currently the build is aborted if the branch tip is at a commit, which was committed with the email of the 'Eclipse Platform Bot'. This is done to prevent rebuilds after a commit for a SWT native binary rebuild was pushed by the bot. But because that bot is also used for other kind of commits, this test leads to false positives. This is a consequence of

This reworks the pipeline to check if the head commit has a SWT-native-binary build tag attached, which is a more precise indicator.

This also fixes the check if a native rebuild is enforced, when testing if the build can be skipped.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 18, 2025

Test Results

   545 files  + 6     545 suites  +6   33m 22s ⏱️ + 6m 5s
 4 402 tests +37   4 384 ✅ +35   18 💤 +3  0 ❌  - 1 
16 732 runs  +37  16 592 ✅ +35  140 💤 +3  0 ❌  - 1 

Results for commit 8ccfeae. ± Comparison against base commit b339485.

♻️ This comment has been updated with latest results.

@HannesWell HannesWell force-pushed the refine-binaries-build-commit-check branch 2 times, most recently from f4c1958 to 005a7e8 Compare June 18, 2025 22:44
@HannesWell
Copy link
Member Author

Similar to eclipse-equinox/equinox#1038, an in-depth analysis showed that the pipeline does in fact not get into an endless native rebuild loop in case the check for a SWT-native-binary build tag is removed. Only one new build is triggered, when a commit for a launcher binary rebuild is pushed (as usual for a push), which does not rebuild the native binaries again (because the latest SWT-native-binary tag points to the then HEAD commit).
I therefore think it's better to continue with that solution as it also allows to simplify the overall pipeline and an extra build after a native rebuild seems acceptable to me. Does anybody disagree?

@HannesWell HannesWell force-pushed the refine-binaries-build-commit-check branch 2 times, most recently from e64dc22 to 2ab867f Compare June 18, 2025 23:50
@HannesWell HannesWell marked this pull request as draft June 19, 2025 00:06
@HannesWell HannesWell changed the title [Build] Refine check for SWT native binary rebuild commit [Build] Remove check for SWT native binary rebuild commit Jun 19, 2025
@HannesWell HannesWell force-pushed the refine-binaries-build-commit-check branch from 2ab867f to d10bb3f Compare June 19, 2025 13:42
@HannesWell HannesWell marked this pull request as ready for review June 19, 2025 13:49
@HannesWell HannesWell force-pushed the refine-binaries-build-commit-check branch from d10bb3f to 8e548cc Compare June 19, 2025 15:24
Currently the build is aborted if the branch tip is at a commit, which
was committed with the email of the 'Eclipse Platform Bot'. This was
done with the intention to prevent (endless) rebuilds after a commit for
a SWT native binary rebuild was pushed by the bot. But because that bot
is also used for other kind of commits, this test leads to false
positives.

An in-depth analysis showed that the pipeline does in fact not get into
an endless native rebuild loop in case that check is removed. Only one
new build is triggered, when a commit for a SWT native binary rebuild is
pushed (as usual for a push), which does not rebuild the native binaries
again, because the latest SWT-native-binary tag points to the then HEAD
commit.
So this reworks the pipeline to just remove that check.

This implicitly also fixes the currently not working check if a native
rebuild is enforced, when testing if the build can be skipped.
@HannesWell HannesWell force-pushed the refine-binaries-build-commit-check branch 3 times, most recently from a15fdfa to 8ccfeae Compare June 19, 2025 16:19
@HannesWell
Copy link
Member Author

Similar to eclipse-equinox/equinox#1038, an in-depth analysis showed that the pipeline does in fact not get into an endless native rebuild loop in case the check for a SWT-native-binary build tag is removed. Only one new build is triggered, when a commit for a launcher binary rebuild is pushed (as usual for a push), which does not rebuild the native binaries again (because the latest SWT-native-binary tag points to the then HEAD commit).

Finally I got a full run that confirms this, so I consider this ready for submission (as there were no objections).
This approach also has the advantage that after a native binaries rebuild the master build (should) complete successfully and is not aborted, which the latter is interpreted and displayed as build failure by the GH UI.

@HannesWell HannesWell merged commit f92b752 into master Jun 19, 2025
17 checks passed
@HannesWell HannesWell deleted the refine-binaries-build-commit-check branch June 19, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants