Simplify control example browser tab content loading #2286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laeubi
reviewed
Jul 8, 2025
Contributor
laeubi
left a comment
laeubi
left a comment
There was a problem hiding this comment.
It seems a bit odd to read in everything as lines just to later join them again .. you can consider using getAllBytes() and wrap into a string directly instead of using a BufferedReader...
examples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/controlexample/BrowserTab.java
Outdated
Show resolved
Hide resolved
examples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/controlexample/BrowserTab.java
Outdated
Show resolved
Hide resolved
examples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/controlexample/BrowserTab.java
Show resolved
Hide resolved
akurtakov
force-pushed
the
master
branch
3 times, most recently
from
a3a7ce4 to
fe60b56
Compare
Member
Author
|
Thanks for giving it more thought (it should be good now) - I just did the first thing that came to my mind as it was already a simplification :). |
laeubi
reviewed
Jul 8, 2025
examples/org.eclipse.swt.examples/src/org/eclipse/swt/examples/controlexample/BrowserTab.java
Outdated
Show resolved
Hide resolved
Going symbol by symbol nowadays is just time lost and even makes code harder to read. Load as UTF-8 to ease testing with various content. Fix warnings in browser-content.html
Contributor
Member
Author
|
This change in snippets can not make SWT.test_isLocal to fail and this issue has happened last week in another PR. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going symbol by symbol nowadays is just time lost and even makes code harder to read.