Skip to content

Conversation

@Theo-Dann-Muirhead-Renesas
Copy link
Contributor

Fix for issue 344.

Running snippet 62 and double clicking used to register two up events but only one down event when there should also have been two. This was due to the use of SWT.MouseDoubleClick instead of SWT.MouseDown. I have modified it such that in the event SWT.MouseDoubleClick fails, SWT.MouseDown is tried instead. This keeps the double click as an option for the future if support is added.

I also changed the behaviour so triple clicks and higher are now treated as double clicks rather than being ignored.

@akurtakov
Copy link
Member

Just as a note for the future - please squash all your commits into single one for such small patches. Merge commits are strongly discouraged in this repo.

@Theo-Dann-Muirhead-Renesas
Copy link
Contributor Author

How do I squash the commits in my fork? I can't see a way to do that

@akurtakov
Copy link
Member

https://www.datacamp.com/tutorial/git-squash-commits looks like good explanation.

@akurtakov
Copy link
Member

akurtakov commented Jul 9, 2025

image
from Egit - open History view, select the commits you want to squash, right click, Modify, Squash

@Theo-Dann-Muirhead-Renesas
Copy link
Contributor Author

{D0E10337-6F9C-41DF-BD29-66ACAE0C56B3}
I do not have that option

@akurtakov
Copy link
Member

Most likely this is because you try to squash commits from different chains and also include merge commits.
It might be easier to start a new branch from master and cherry-pick only the commit you want in it.
Try to always rebase and not merge to reduce cases like that.

@Theo-Dann-Muirhead-Renesas
Copy link
Contributor Author

I made a new pull request with just the one commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants