Correct GC tests to properly execute at non-default device zoom #2343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Some GC tests are explicitly executed on a non-default device zoom. However, most of them use a GC as subject to test that is created in a setup method that is thus using the original device zoom instead of the non-default one set by the test afterwards. This change ensures that when executing a test with a non-default device zoom, the GC used as subject to test is recreated to rely on that modified device zoom.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some GC tests are explicitly executed on a non-default device zoom. However, most of them use a GC as subject to test that is created in a setup method that is thus using the original device zoom instead of the non-default one set by the test afterwards.
This change ensures that when executing a test with a non-default device zoom, the GC used as subject to test is recreated to rely on that modified device zoom.
Contributes to #2334