[Win32] Remove obsolete zoom parameter for refreshing GC handle #2407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
akoch-yatta
approved these changes
Aug 11, 2025
Contributor
akoch-yatta
left a comment
akoch-yatta
left a comment
There was a problem hiding this comment.
Getting rid of the probably confusing parameter and inlining the logic into image makes sense. tested it with fixed zoom, integer200 and quarter
When refreshing a GC with another zoom, that zoom is unnecessarily duplicated in the DrawableWrapper of the Image and as a parameter of the refresh method of the GC. This refresh method than unnecessarily uses that zoom to initialize the GCData's native zoom with it, even though that's overwritten with the proper zoom by initializing the GC with the DrawableWrapper afterwards. This change removes the zoom duplication by removing the parameter in the refresh method of the GC. It removes the unnecessary assignment of the GCData's native zoom and moves the check for whether a refresh is necessary because of a zoom change from the GC to the image. In addition, it ensures that the memGC of an image is not accidentally set to null in case the memGC's zoom does already fit to the requested zoom.
HeikoKlare
force-pushed
the
gc-remove-obsolete-parameter
branch
from
f45bd64 to
7e00285
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When refreshing a GC with another zoom, that zoom is unnecessarily duplicated in the DrawableWrapper of the Image and as a parameter of the refresh method of the GC. This refresh method than unnecessarily uses that zoom to initialize the GCData's native zoom with it, even though that's overwritten with the proper zoom by initializing the GC with the DrawableWrapper afterwards.
This change removes the zoom duplication by removing the parameter in the refresh method of the GC. It removes the unnecessary assignment of the GCData's native zoom and moves the check for whether a refresh is necessary because of a zoom change from the GC to the image. In addition, it ensures that the memGC of an image is not accidentally set to null in case the memGC's zoom does already fit to the requested zoom.