Check if the browser is disposed before scheduling runnable in Edge #2408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HeikoKlare
reviewed
Aug 11, 2025
bundles/org.eclipse.swt/Eclipse SWT Browser/win32/org/eclipse/swt/browser/Edge.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT Browser/win32/org/eclipse/swt/browser/Edge.java
Outdated
Show resolved
Hide resolved
fedejeanne
force-pushed
the
check_browser_disposed_in_callback
branch
from
d02d6d1 to
7bfc170
Compare
HeikoKlare
approved these changes
Aug 11, 2025
For the unlikely (but possible) case in which the callback is executed too late and the browser/display has already been disposed. Add a new private method to funnel all calls to Display::asyncExec and check there if the display is still usable.
HeikoKlare
force-pushed
the
check_browser_disposed_in_callback
branch
from
7bfc170 to
a513d45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the unlikely (but possible) case in which the callback is executed too late and the browser/display has already been disposed.