Unify strict checks and extend ImageDataProvider checks to GTK and Cocoa #2410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arunjose696
commented
Aug 11, 2025
arunjose696
commented
- Move strict checks into a separate class.
- Extend strict check to verify if imageData is linearly scaled by the imageDataProvider in GTK and COCOA implementations.
arunjose696
force-pushed
the
refactorStrictChecks
branch
from
44b4415 to
176f715
Compare
HeikoKlare
reviewed
Aug 11, 2025
bundles/org.eclipse.swt/Eclipse SWT/common/org/eclipse/swt/internal/StrictChecks.java
Outdated
Show resolved
Hide resolved
Contributor
arunjose696
force-pushed
the
refactorStrictChecks
branch
from
176f715 to
d8dcba1
Compare
HeikoKlare
force-pushed
the
refactorStrictChecks
branch
from
d8dcba1 to
77b7baf
Compare
Move strict checks into a separate class. Extend strict check to verify if imageData is linearly scaled by an ImageDataProvider in GTK and Cocoa implementations.
HeikoKlare
force-pushed
the
refactorStrictChecks
branch
from
77b7baf to
595fc0b
Compare
HeikoKlare
changed the title
HeikoKlare
approved these changes
Aug 11, 2025
Contributor
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
Good to have this streamlined and consistent. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.