[Win32] Ensure Image#getImageData() returns no internal data #2427
Conversation
There was a problem hiding this comment.
It fixes the contract "Modifications made to the returned {@code ImageData} will not affect this Image" but it breaks the other tests: test_imageDataIsCached, test_getBoundsInPixels and test_getImageDataCurrentZoom.
HeikoKlare
force-pushed
the
regression-1989
branch
from
4f50ca9 to
baa8f49
Compare
|
@ShahzaibIbrahim I adapted |
|
@HeikoKlare I tried with your latest changes and they are not failing anymore. I cannot mark my review stale for some reason. |
A caching mechanism for ImageData introduced to some provider implementations inside the Image class leads to Image#getImageData() returning an ImageData object, which if modified affects the underlying Image. This contradicts the contract of that method, which states that changes to that object will not affect the Image. This change ensures that Image#getImagetData() only returns objects that are not used internal of the Image instance. To this end, clones of the ImageData are created where necessary.
HeikoKlare
force-pushed
the
regression-1989
branch
from
baa8f49 to
8deabcf
Compare
akoch-yatta
left a comment
akoch-yatta
left a comment
There was a problem hiding this comment.
Change makes sense for the described regression as it will clone the ImageData when they are returned via API call. This will ensure the Image itself to be unchanged. I tested the changed with and without monitor specific scaling for regression and didn't find any.
Good to go from my side
|
Thanks @HeikoKlare! I have also verified the fix in our product. |
4 participants
This fixes a regression from #1989 as reported by @sratz: #1989 (comment)
A caching mechanism for ImageData introduced to some provider implementations inside the Image class leads to Image#getImageData() returning an ImageData object, which if modified affects the underlying Image. This contradicts the contract of that method, which states that changes to that object will not affect the Image.
This change ensures that Image#getImagetData() only returns objects that are not used internal of the Image instance. To this end, clones of the ImageData are created where necessary.