Skip to content

Use SystemParametersInfoForDpi in Caret #2471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use SystemParametersInfoForDpi in Caret #2471

wants to merge 1 commit into from
+4 −4

Conversation

amartya4256
Copy link
Contributor

This PR uses SystemParametersInfoForDpi in Caret instead of SystemParametersInfo for better monitor specific scaling.

Contributes to #62 and #128

@amartya4256 amartya4256 linked an issue Sep 1, 2025 that may be closed by this pull request
Use SystemParametersInfoForDpi in Caret vi-eclipse/Eclipse-Platform#433
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 1, 2025 •
edited
Loading

Test Results

  351 files   -   195    351 suites   - 195   12m 21s ⏱️ - 19m 11s
4 086 tests  -   340  4 065 ✅  -   344  21 💤 + 4  0 ❌ ±0 
8 719 runs   - 8 031  8 658 ✅  - 7 965  61 💤  - 66  0 ❌ ±0 

Results for commit 38cac4f. ± Comparison against base commit f6de513.

This pull request removes 340 tests. 
AllGTKTests Test_GtkConverter ‑ test_HeuristicASCII_dollarSign
AllGTKTests Test_GtkConverter ‑ test_HeuristicASCII_emptyString
AllGTKTests Test_GtkConverter ‑ test_HeuristicASCII_letterA
AllGTKTests Test_GtkConverter ‑ test_HeuristicASCII_letters
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16LE_null
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_AsciiLetters
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_Asciiletter
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_LotsOfLetters
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_letter
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_letters
…
This pull request skips 12 tests. 
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_Constructor_multipleInstantiationsInDifferentThreads[browser flags: 0]
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_setUrl_local[browser flags: 0]
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_browser_Browser ‑ test_setUrl_remote[browser flags: 0]
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_custom_StyledText ‑ test_GlyphMetricsOnTab_Bug549110
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_custom_StyledText ‑ test_bug551335_lostStyles
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_custom_StyledText ‑ test_clipboardCarryover
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_custom_StyledText ‑ test_lineStyleListener_invalidStyles_render
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_custom_StyledText ‑ test_lineStyleListener_stylesAndRanges_render
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_custom_StyledText ‑ test_lineStyleListener_styles_render
org.eclipse.swt.tests.junit.Test_org_eclipse_swt_custom_StyledText ‑ test_setStyleRanges_render
…

♻️ This comment has been updated with latest results.

@amartya4256
Use SystemParametersInfoForDpi in Caret win32 eclipse-platform#62
38cac4f 
This commit adds the usage of the new API SystemParametersInfoForDpi in
Caret for resizing the caret and other places.

contributes to
eclipse-platform#62 and
eclipse-platform#128
@amartya4256 amartya4256 force-pushed the amartya4256/use_new_api_in_caret branch from e13d50f to 38cac4f Compare September 2, 2025 07:57
@amartya4256 amartya4256 mentioned this pull request Sep 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use SystemParametersInfoForDpi in Caret
1 participant
@amartya4256