Skip to content

GTK4: Fix GTK4 shell location test. #2523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2025
Merged

GTK4: Fix GTK4 shell location test. #2523

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions ...swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_widgets_Shell.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,6 +457,10 @@ public void test_getImeInputMode() {
@Override
@Test
public void test_getLocation() {
//Setting location for Windows is not supported in GTK4
if (isGTK4()) {
return;
}
shell.setLocation(10,15);
assertEquals(":a:", 10, shell.getLocation().x);
assertEquals(":b:", 15, shell.getLocation().y);
Expand Down Expand Up @@ -999,4 +1003,27 @@ public void test_Issue450_NoShellActivateOnSetFocus() {
}
}
}

@Override
public void test_setLocationLorg_eclipse_swt_graphics_Point() {
//Setting location for Windows is not supported in GTK4
if (isGTK4()) {
return;
}
super.test_setLocationLorg_eclipse_swt_graphics_Point();
}

@Override
public void test_setLocationII() {
//Setting location for Windows is not supported in GTK4
if (isGTK4()) {
return;
}
super.test_setLocationII();
}

public static boolean isGTK4() {
String gtkVersion = System.getProperty("org.eclipse.swt.internal.gtk.version", "");
return SwtTestUtil.isGTK && gtkVersion.startsWith("4");
}
}
Loading