Allow getting StyledText content as html via getData

[akurtakov]

The key is simply StyledText.getData
Let's have this one as hidden "gem" for testing purposes to ease both testing the implementation and may one day it would be worth exposing as proper API.

[BeckerWdf]

Can you provide more context on this?

[github-actions]

Test Results

  118 files  ±0    118 suites  ±0   11m 27s ⏱️ + 1m 21s
4 432 tests ±0  4 409 ✅  - 2  17 💤 ±0  6 ❌ +2 
  298 runs  ±0    288 ✅  - 2   4 💤 ±0  6 ❌ +2 

For more details on these failures, see this check.

Results for commit 0f986e1. ± Comparison against base commit 35119f0.

[akurtakov]

@BeckerWdf Sure, one can do:

styledText.getData("StyledText.htmlText")

and will get html formatted text or the StyledText content the same as used for clipboard, e.g.

<span style='background-color:#ffffff;padding:0px 0px 0px 0px;'><span style='color:#000000;background-color:#ffffff;font-family:"Noto Sans";font-size:10pt;white-space:pre;'><span style='font-weight:bold;'>test</span></span></span>

[BeckerWdf]

And what is this needed for? What's the bigger use case on that?

[akurtakov]

Export content to html for saving purposes, debugging, enhancing clipboard operations/compatibility and so on development purposes. Html being defacto standard for rendering nowadays gives other opportunities for sure. Do you have concerns?

[akurtakov]

Failing Windows tests are #2516

[mickaelistria]

What about making it an official API method toHTML() ? I think such feature would deserve it, and there are already possible clients for it in eg copy-paste.

[akurtakov]

I would rather have a cycle (or two) experimenting with it before exposing as API, IMO if/when it becomes API it needs tests and be sure that everything is properly exported.

[BeckerWdf]

Do you have concerns?

No I don't. I am just curious.

I am asking my self where the formatting like background-color:#ffffff;padding:0px 0px 0px 0px; are coming from?

[akurtakov]

FWIW, get/setData is the way to give access to SWT internals if/when they are either not ready or should not become API for some reason e.g.

eclipse.platform.swt/bundles/org.eclipse.swt/Eclipse SWT Browser/common/org/eclipse/swt/browser/Browser.java

Line 97 in 35119f0

parent.getDisplay ().setData (NO_INPUT_METHOD, null);

,

eclipse.platform.swt/bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/TaskBar.java

Line 127 in 35119f0

String exePath = (String)item.getData (EXE_PATH_KEY);

,

eclipse.platform.swt/bundles/org.eclipse.swt/Eclipse SWT Browser/win32/org/eclipse/swt/browser/Edge.java

Line 644 in 35119f0

dataDir = (String) display.getData(EDGE_USER_DATA_FOLDER);

,

eclipse.platform.swt/bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Widget.java

Line 2722 in 35119f0

widget.setData(DATA_NATIVE_ZOOM, newZoom);

and so on.

[akurtakov]

Do you have concerns?

No I don't. I am just curious.

I am asking my self where the formatting like background-color:#ffffff;padding:0px 0px 0px 0px; are coming from?

It's the "defaults" of styled text when no StyleRange overwrites it - white background, no padding. Whether it makes sense to have them or not, combine some of the spans and etc. are exactly the things which in order to improve we need easier way to test.
I'm merging this one as it's not adding public API and is truly just an enablement for further work.