Fix specific WidgetWin32Tests to not use Layout #2546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the tests in WidgetWin32Tests assert the size of the controls after DPI_CHANGE. The tests work fine since theres no updateLayout called but its deffered to be executed after the thread is free and hence the controls size are unaffected. However this is risky and layouting can make the values arbitrary and the tests can fail. Hence, we simply test the absolute values without using any Layout in this commit.
Member
|
I have missed when this folder was committed but shouldn't it be in https://github.com/eclipse-platform/eclipse.platform.swt/tree/master/tests/org.eclipse.swt.tests.win32 ? |
Contributor
Contributor
|
They were introduce 1,5 years ago or so. They are unit tests and no component tests (testing not at bundle API level), which is why they are not in the separate Win32 test bundle but in the Win32 fragment. |
Member
|
I see. Thanks for the explanation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the tests in WidgetWin32Tests assert the size of the controls after DPI_CHANGE. The tests work fine since theres no updateLayout called but its deffered to be executed after the thread is free and hence the controls size are unaffected. However this is risky and layouting can make the values arbitrary and the tests can fail. Hence, we simply test the absolute values without using any Layout in this PR.